Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supply empty SiPixelLorentzAngle palyoads for forWidth and fromAlignment in autoCondPhase2 for geometry T33 #43482

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 2, 2023

PR description:

Title says it all, addresses #43466 (comment)

PR validation:

runTheMatrix.py --what upgrade -l 26424.0 runs fine and there are no more complaints about missing values in the SiPixelLorentzAngle payload for certain detIds.
I have also plotted the payload before uploading to database with:

getPayloadData.py \
    --plugin pluginSiPixelLorentzAngle_PayloadInspector \
    --plot plot_SiPixelLorentzAngleValues \
    --tag SiPixelLorentzAngle_phase2_IT_v7.1.1_25x100_empty_mc \
    --time_type Run \
    --iovs '{"start_iov": "1", "end_iov": "1"}' \
    --db sqlite_file:SiPixelLorentzAngle_phase2_IT_v7.1.1_25x100_empty_mc.db --test;

the resulting plot is here:

image

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43482/38049

  • This PR adds an extra 12KB to repository

@mmusich mmusich changed the title supply empty SiPixelLorentzAngle palyoads for forWidth and fromAlignment in autoCondPhase2 for geometry T33 supply empty SiPixelLorentzAngle palyoads for forWidth and fromAlignment in autoCondPhase2 for geometry T33 Dec 2, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @consuegs, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks.
@yuanchao, @missirol, @mmusich, @rsreds, @Martin-Grunewald, @fabiocos, @tocheng this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2023

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2023

test parameters:

  • workflow = 26424.0
  • relvals_opt= -w upgrade

@mmusich
Copy link
Contributor Author

mmusich commented Dec 2, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9459b5/36280/summary.html
COMMIT: ddc6325
CMSSW: CMSSW_14_0_X_2023-12-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43482/36280/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Dec 3, 2023

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants