[RECONSTRUCTION] Define missing assignment operator to fix warnings reported in DEVEL IBs

[aandvalenzuela]

Hello,

This PR solves the DEVEL warnings on deprecated implicit assignment operators present in the IBs on the DataFormats modules.

This PR is part of a campaign trying to get rid of warnings of this kind:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a2b36a15ce1eab94715509bc9f78be2f/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-30-2300/src/DataFormats/SiStripCommon/test/plugins/examples_SiStripFecKey.cc: In member function 'virtual void examplesSiStripFecKey::beginJob()':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a2b36a15ce1eab94715509bc9f78be2f/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-30-2300/src/DataFormats/SiStripCommon/test/plugins/examples_SiStripFecKey.cc:69:12: warning: implicitly-declared 'SiStripFecKey& SiStripFecKey::operator=(const SiStripFecKey&)' is deprecated [-Wdeprecated-copy]
    69 |   equals = valid;
      |            ^~~~~
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a2b36a15ce1eab94715509bc9f78be2f/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-30-2300/src/DataFormats/SiStripCommon/test/plugins/examples_SiStripFecKey.cc:14:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a2b36a15ce1eab94715509bc9f78be2f/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-30-2300/src/DataFormats/SiStripCommon/interface/SiStripFecKey.h:65:3: note: because 'SiStripFecKey' has user-provided 'SiStripFecKey::SiStripFecKey(const SiStripFecKey&)'
   65 |   SiStripFecKey(const SiStripFecKey&);
      |   ^~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a2b36a15ce1eab94715509bc9f78be2f/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-30-2300/src/DataFormats/SiStripCommon/test/plugins/test_SiStripFecKey.cc: In member function 'virtual void testSiStripFecKey::beginJob()':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/a2b36a15ce1eab94715509bc9f78be2f/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-30-2300/src/DataFormats/SiStripCommon/test/plugins/test_SiStripFecKey.cc:116:26: warning: implicitly-declared 'SiStripFecKey& SiStripFecKey::operator=(const SiStripFecKey&)' is deprecated [-Wdeprecated-copy]
   116 |                   tmp5 = tmp1;
      |                          ^~~~
In file included from /data/cmsbld/je

Thanks,
Andrea

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43462/38015

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master.

It involves the following packages:

• DataFormats/BTauReco (reconstruction)
• DataFormats/EgammaCandidates (reconstruction)
• DataFormats/METReco (reconstruction)
• DataFormats/ParticleFlowReco (reconstruction)
• DataFormats/SiStripCommon (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@varuns23, @schoef, @nhanvtran, @ram1123, @sameasy, @JyothsnaKomaragiri, @rappoccio, @jdolen, @mmusich, @a-kapoor, @threus, @AlexDeMoor, @emilbols, @andrzejnovak, @Sam-Harper, @jainshilpi, @ahinzmann, @Senphy, @erikbutz, @Ming-Yan, @echabert, @VinInn, @robervalwalsh, @rovere, @mariadalfonso, @AnnikaStein, @hatakeyamak, @sobhatta, @Prasant1993, @alesaggio, @gouskos, @afiqaize, @mmarionncern, @jdamgov, @lgray, @seemasharmafnal, @missirol, @gkasieczka, @jlidrych, @demuller this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aandvalenzuela]

please test for CMSSW_14_0_DEVEL_X

[aandvalenzuela]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-213c73/36225/summary.html
COMMIT: f599317
CMSSW: CMSSW_14_0_DEVEL_X_2023-11-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43462/36225/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 48 lines from the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 1181
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3368829
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-213c73/36226/summary.html
COMMIT: f599317
CMSSW: CMSSW_14_0_X_2023-11-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43462/36226/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 21 lines to the logs
• Reco comparison results: 26 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 1186
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3368824
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1
technical, no change to reco

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1