Replace CPP11_auto_ptr with std::unique_ptr #43444

iarspider · 2023-11-30T10:41:20Z

PR description:

This is part of a campaign to remove std::auto_ptr.

CPP11_auto_ptr was #defined as std::unique_ptr in Alignment/Geners/interface/CPP11_auto_ptr.hh, so the change is completely transparent

PR validation:

Bot tests, no changes are expected.

…ned as std::unique_ptr)

iarspider · 2023-11-30T10:41:26Z

please test

cmsbuild · 2023-11-30T10:48:33Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43444/37988

ERROR: Build errors found during clang-tidy run.

   60 |     return !(cs.fail() || cs.bad() || os.fail() || os.bad());
      |                           ^~
Alignment/Geners/interface/CompressedIO.hh:92:12: error: no matching function for call to 'read_item' [clang-diagnostic-error]
   92 |     return read_item<Item, std::istream>(cs);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Alignment/Geners/src/stringArchiveIO.cc:76:41: note: in instantiation of function template specialization 'gs::read_compressed_item<gs::StringArchive>' requested here
--
Alignment/Geners/interface/GenericIO.hh:304:50: error: non-const lvalue reference to type 'std::ostream' (aka 'basic_ostream<char>') cannot bind to a value of unrelated type 'gs::CStringStream' [clang-diagnostic-error]
  304 |       return (processClassId ? s.classId().write(os) : true) && s.write(os) && !os.fail();
      |                                                  ^~
Alignment/Geners/interface/ProcessItem.hh:374:77: note: in instantiation of member function 'gs::GenericWriter<gs::CStringStream, char, gs::StringArchive, gs::Int2Type<4>>::process' requested here
--
Alignment/Geners/interface/GenericIO.hh:304:73: error: non-const lvalue reference to type 'std::ostream' (aka 'basic_ostream<char>') cannot bind to a value of unrelated type 'gs::CStringStream' [clang-diagnostic-error]
  304 |       return (processClassId ? s.classId().write(os) : true) && s.write(os) && !os.fail();
      |                                                                         ^~
Alignment/Geners/interface/StringArchive.hh:43:30: note: passing argument to parameter 'of' here
--
Alignment/Geners/interface/GenericIO.hh:304:81: error: cannot initialize object parameter of type 'const std::basic_ios<char>' with an expression of type 'gs::CStringStream' [clang-diagnostic-error]
  304 |       return (processClassId ? s.classId().write(os) : true) && s.write(os) && !os.fail();
      |                                                                                 ^~
Alignment/Geners/interface/GenericIO.hh:504:17: warning: use std::make_unique instead [modernize-make-unique]
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2023-11-30T11:06:39Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43444/37989

This PR adds an extra 84KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43444/37989/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43444/37989/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly

cmsbuild · 2023-11-30T11:18:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43444/37990

This PR adds an extra 84KB to repository

cmsbuild · 2023-11-30T11:19:02Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

Alignment/Geners (alca)
JetMETCorrections/FFTJetModules (analysis)
JetMETCorrections/FFTJetObjects (analysis)
JetMETCorrections/InterpolationTables (analysis)

@saumyaphor4252, @consuegs, @cmsbuild, @perrotta, @tvami can you please review it and eventually sign? Thanks.
@jdolen, @rappoccio, @ahinzmann, @jdamgov, @yuanchao, @clelange, @mmarionncern, @gkasieczka, @rsreds, @mmusich, @schoef, @adewit, @tocheng, @gouskos, @nhanvtran, @seemasharmafnal, @mariadalfonso this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

iarspider · 2023-11-30T11:36:55Z

please test

cmsbuild · 2023-11-30T12:41:36Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e092b4/36198/summary.html
COMMIT: 3d5c5ef
CMSSW: CMSSW_14_0_X_2023-11-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

5.1

----- Begin Fatal Exception 30-Nov-2023 13:00:27 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_8TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/5.1_TTbarFS


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

135.4

----- Begin Fatal Exception 30-Nov-2023 13:00:28 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named ZEE_13TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/135.4_ZEEFS_13


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

138.4

----- Begin Fatal Exception 30-Nov-2023 13:00:46 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_RAW2DIGI_L1Reco_RECO_ALCA_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/138.4_PromptCollisions2021


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
139.005139.005_AlCaPhiSym2021/step2_AlCaPhiSym2021.log
138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log

Expand to see more relval errors ...

AddOn Tests

fastsim

----- Begin Fatal Exception 30-Nov-2023 12:59:14 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_8TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/fastsim


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 30-Nov-2023 12:59:14 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_13TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/fastsim1


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 30-Nov-2023 12:59:14 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_13TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36198/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/fastsim2


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

iarspider · 2023-11-30T12:49:22Z

please test with cms-sw/cmsdist#8847

smuzaffar · 2023-11-30T15:00:54Z

please test

new IB is available

cmsbuild · 2023-11-30T18:26:30Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e092b4/36207/summary.html
COMMIT: 3d5c5ef
CMSSW: CMSSW_14_0_X_2023-11-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43444/36207/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 25 lines from the logs
Reco comparison results: 27 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3370032
DQMHistoTests: Total failures: 1194
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3368816
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

perrotta · 2023-11-30T21:12:41Z

+alca

Tests show quite several differences in DQM for ParticleFlow JetCorrections. That was suspicious, at the beginning. Then I realized that this is a common "feature" of the latest PR tests in the IB (se for example the completely unrelated Update ROCm tools #43451), and therefore this PR can be signed.
The issue of those spurious differences is worth being investigated.

tvami · 2023-12-04T14:02:00Z

+analysis

cmsbuild · 2023-12-04T14:02:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-12-04T15:37:57Z

+1

Replace CPP11_auto_ptr with std::unique_ptr (CPP11_auto_ptr was #defi…

06ade60

…ned as std::unique_ptr)

cmsbuild added this to the CMSSW_14_0_X milestone Nov 30, 2023

cmsbuild added analysis-pending alca-pending pending-signatures orp-pending tests-started code-checks-pending labels Nov 30, 2023

cmsbuild added code-checks-rejected tests-pending code-checks-pending and removed code-checks-pending tests-started code-checks-rejected labels Nov 30, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 30, 2023

Add missing include

3d5c5ef

iarspider force-pushed the no-cpp11-autoptr branch from d489257 to 3d5c5ef Compare November 30, 2023 11:11

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 30, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 30, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 30, 2023

cmsbuild added tests-rejected and removed tests-started labels Nov 30, 2023

cmsbuild added requires-external tests-started and removed tests-rejected labels Nov 30, 2023

cmsbuild removed the requires-external label Nov 30, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 30, 2023

cmsbuild added alca-approved and removed alca-pending labels Nov 30, 2023

perrotta mentioned this pull request Nov 30, 2023

Spurious comparison differences in workflows 136.X, 141.044, 4.54, ... #43456

Closed

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Dec 4, 2023

cmsbuild added orp-approved and removed orp-pending labels Dec 4, 2023

cmsbuild merged commit 821d304 into cms-sw:master Dec 4, 2023

cmsbuild mentioned this pull request Dec 5, 2023

Phase2 Trigger Primitive generation for Ecal Barrel #42633

Merged

iarspider deleted the no-cpp11-autoptr branch February 27, 2024 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace CPP11_auto_ptr with std::unique_ptr #43444

Replace CPP11_auto_ptr with std::unique_ptr #43444

iarspider commented Nov 30, 2023

iarspider commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

iarspider commented Nov 30, 2023 via email

cmsbuild commented Nov 30, 2023

iarspider commented Nov 30, 2023

smuzaffar commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

perrotta commented Nov 30, 2023

tvami commented Dec 4, 2023

cmsbuild commented Dec 4, 2023

rappoccio commented Dec 4, 2023

Replace CPP11_auto_ptr with std::unique_ptr #43444

Replace CPP11_auto_ptr with std::unique_ptr #43444

Conversation

iarspider commented Nov 30, 2023

PR description:

PR validation:

iarspider commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

iarspider commented Nov 30, 2023 via email

cmsbuild commented Nov 30, 2023

RelVals

RelVals-INPUT

AddOn Tests

iarspider commented Nov 30, 2023

smuzaffar commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

Comparison Summary

perrotta commented Nov 30, 2023

tvami commented Dec 4, 2023

cmsbuild commented Dec 4, 2023

rappoccio commented Dec 4, 2023