Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex174C Backport the fix in #43418 on ZDC geometry to update the 2023 Run3 geometry to be used for te Heavy Ion MC #43443

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

bsunanda
Copy link
Contributor

PR description:

Backport the fix in #43418 on ZDC geometry to update the 2023 Run3 geometry to be used for te Heavy Ion MC. This replaces #43421

PR validation:

Use the runTheMatrix test workflows and overlap checks

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport #43418 and replaces #43421 which is closed

…un3 geometry to be used for te Heavy Ion MC
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/Geometry (upgrade, geometry)
  • Geometry/CMSCommonData (upgrade, geometry)
  • Geometry/ForwardCommonData (geometry)
  • Geometry/ForwardSimData (geometry)

@cmsbuild, @makortel, @mdhildreth, @srimanob, @bsunanda, @civanch, @Dr15Jones can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @vargasa, @slomeo, @fabiocos this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7baa83/36191/summary.html
COMMIT: d4685bd
CMSSW: CMSSW_13_2_X_2023-11-29-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43443/36191/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198754
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Nov 30, 2023

+1

@civanch
Copy link
Contributor

civanch commented Nov 30, 2023

@srimanob, this is a minimal set of ZDC geometry for heavy ion run.

@civanch
Copy link
Contributor

civanch commented Dec 2, 2023

This PR may be merged even if in the current plan this release does not assumed for 2023 HI MC production.

@srimanob
Copy link
Contributor

srimanob commented Dec 3, 2023

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2861c6e into cms-sw:CMSSW_13_2_X Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants