Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trackingParabolicMf for iterative tracking starting from phase-1 #43434

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Nov 29, 2023

This is essentially a technical PR for physics with a small speedup improvement in tracking.

Initially this change was already made in LS1 in 7X release cycle (!), but got lost due to automated git forward ports.

More details are available in #41557

Special BPH validation was done via https://its.cern.ch/jira/browse/PDMVRELVALS-192

@slava77
Copy link
Contributor Author

slava77 commented Nov 29, 2023

type tracking

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43434/37970

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

  • Configuration/Eras (operations)

@cmsbuild, @davidlange6, @fabiocos, @rappoccio, @antoniovilela can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @missirol, @AnnikaStein, @fabiocos this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Nov 29, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3b93e/36173/summary.html
COMMIT: b8f4eb7
CMSSW: CMSSW_14_0_X_2023-11-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43434/36173/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 229 lines to the logs
  • Reco comparison results: 16614 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3372451
  • DQMHistoTests: Total failures: 24827
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3347590
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.066 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 141.044 ): -0.066 KiB JetMET/SUSYDQM
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants