[HGCAL trigger] Update ECON-T BestChoice NData #43431

jbsauvan · 2023-11-29T13:13:50Z

PR description:

Update configuration of the number of trigger cells sent from the ECON-T with the BestChoice algorithm, as a function of the number of connected elinks
Following ECON-T specifications document
To be noted that the BestChoice algorithm is not used in default sequences; therefore no changes are expected.

Associated internal PRs and reviews:

Update number of TCs selected by BestChoice hgc-tpg/cmssw#45

PR validation:

Tested D86, D92, D94 workflows

runTheMatrix.py -w upgrade -l 20034.0 --maxSteps=2 & # D86
runTheMatrix.py -w upgrade -l 22434.0 --maxSteps=2 & # D92
runTheMatrix.py -w upgrade -l 23234.0 --maxSteps=2 & # D94

cmsbuild · 2023-11-29T13:22:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43431/37965

This PR adds an extra 20KB to repository

cmsbuild · 2023-11-29T13:22:45Z

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

L1Trigger/L1THGCal (l1, upgrade)

@srimanob, @aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @missirol, @lgray this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

aloeliger · 2023-11-30T10:21:56Z

please test

cmsbuild · 2023-11-30T11:35:44Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86e77c/36194/summary.html
COMMIT: e8beb2e
CMSSW: CMSSW_14_0_X_2023-11-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

5.1

----- Begin Fatal Exception 30-Nov-2023 11:51:41 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_8TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/5.1_TTbarFS


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

135.4

----- Begin Fatal Exception 30-Nov-2023 11:51:41 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named ZEE_13TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/135.4_ZEEFS_13


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

138.4

----- Begin Fatal Exception 30-Nov-2023 11:51:56 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_RAW2DIGI_L1Reco_RECO_ALCA_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/138.4_PromptCollisions2021


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
139.005139.005_AlCaPhiSym2021/step2_AlCaPhiSym2021.log
138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log

Expand to see more relval errors ...

AddOn Tests

fastsim

----- Begin Fatal Exception 30-Nov-2023 11:50:47 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_8TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/fastsim


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 30-Nov-2023 11:50:47 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_13TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/fastsim1


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 30-Nov-2023 11:50:47 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_13TeV_TuneCUETP8M1_cfi_GEN_SIM_RECOBEFMIX_DIGI_L1_DIGI2RAW_L1Reco_RECO_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTfClassifier/MkFitDisplacedRegionalOnly_Run3_12_5_0_pre5.pb anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36194/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/fastsim2


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Types.py(881): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(381): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Mixins.py(516): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02813/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2023-11-29-2300/src/FWCore/ParameterSet/python/Config.py(1502): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

jbsauvan · 2023-12-01T08:56:51Z

The failures in the tests seem unrelated to this PR

epalencia · 2023-12-01T09:17:41Z

Please test

aloeliger · 2023-12-01T09:19:22Z

I'm not seeing any other PRs with this kind of error, I guess we'll see if it is temporary.

cmsbuild · 2023-12-01T12:10:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86e77c/36235/summary.html
COMMIT: e8beb2e
CMSSW: CMSSW_14_0_X_2023-11-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43431/36235/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 68 lines to the logs
Reco comparison results: 22 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3370032
DQMHistoTests: Total failures: 1196
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3368814
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

aloeliger · 2023-12-01T12:29:55Z

+l1

Trivial changes, no visible results expected

srimanob · 2023-12-02T09:23:19Z

+Upgrade

cmsbuild · 2023-12-02T09:23:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

srimanob · 2023-12-02T09:24:55Z

Note to @jbsauvan @aloeliger

You may follow up to fix the warning later. Not relate to this PR.

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-30-2300/src/L1Trigger/L1THGCal/src/backend/HGCalClusteringImpl.cc:87:26: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
   87 |     if (targetClu < 0 && isSeed[itc])
      |                          ^~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-30-2300/src/L1Trigger/L1THGCal/src/backend/HGCalClusteringImpl.cc:301:9: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
  301 |     if (isSeed[itc])
      |         ^~~~~~~~~~~
2 warnings generated.

antoniovilela · 2023-12-04T12:52:07Z

+1

jbsauvan · 2023-12-04T15:30:05Z

Note to @jbsauvan @aloeliger

You may follow up to fix the warning later. Not relate to this PR.

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-30-2300/src/L1Trigger/L1THGCal/src/backend/HGCalClusteringImpl.cc:87:26: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
   87 |     if (targetClu < 0 && isSeed[itc])
      |                          ^~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-30-2300/src/L1Trigger/L1THGCal/src/backend/HGCalClusteringImpl.cc:301:9: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
  301 |     if (isSeed[itc])
      |         ^~~~~~~~~~~
2 warnings generated.

Hi @srimanob
Thanks for the notice!
Indeed this is something I noted that should be fixed.

Update BC NData

e8beb2e

cmsbuild added this to the CMSSW_14_0_X milestone Nov 29, 2023

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Nov 29, 2023

jbsauvan mentioned this pull request Nov 29, 2023

Integration of BestChoice NData update hgc-tpg/cmssw#69

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 29, 2023

cmsbuild added tests-started and removed tests-pending labels Nov 30, 2023

cmsbuild added tests-rejected and removed tests-started labels Nov 30, 2023

cmsbuild added tests-started and removed tests-rejected labels Dec 1, 2023

cmsbuild added tests-approved and removed tests-started labels Dec 1, 2023

cmsbuild added l1-approved and removed l1-pending labels Dec 1, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Dec 2, 2023

cmsbuild added orp-approved and removed orp-pending labels Dec 4, 2023

cmsbuild merged commit a11a4ad into cms-sw:master Dec 4, 2023
11 checks passed

This was referenced Dec 4, 2023

Add recipe for pytorch (C++ interface only) cms-sw/cmsdist#8388

Merged

Fix deprecated-copy warnings in CondFormats/PhysicsToolsObjects and PhysicsTools/MVAComputer #43400

Merged

Phase2 Trigger Primitive generation for Ecal Barrel #42633

Merged

srimanob mentioned this pull request Jan 22, 2024

[HGCAL trigger] Update in geometry tester class #43704

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HGCAL trigger] Update ECON-T BestChoice NData #43431

[HGCAL trigger] Update ECON-T BestChoice NData #43431

jbsauvan commented Nov 29, 2023

cmsbuild commented Nov 29, 2023

cmsbuild commented Nov 29, 2023

aloeliger commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

jbsauvan commented Dec 1, 2023

epalencia commented Dec 1, 2023

aloeliger commented Dec 1, 2023

cmsbuild commented Dec 1, 2023

aloeliger commented Dec 1, 2023

srimanob commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

srimanob commented Dec 2, 2023

antoniovilela commented Dec 4, 2023

jbsauvan commented Dec 4, 2023

[HGCAL trigger] Update ECON-T BestChoice NData #43431

[HGCAL trigger] Update ECON-T BestChoice NData #43431

Conversation

jbsauvan commented Nov 29, 2023

PR description:

PR validation:

cmsbuild commented Nov 29, 2023

cmsbuild commented Nov 29, 2023

aloeliger commented Nov 30, 2023

cmsbuild commented Nov 30, 2023

RelVals

RelVals-INPUT

AddOn Tests

jbsauvan commented Dec 1, 2023

epalencia commented Dec 1, 2023

aloeliger commented Dec 1, 2023

cmsbuild commented Dec 1, 2023

Comparison Summary

aloeliger commented Dec 1, 2023

srimanob commented Dec 2, 2023

cmsbuild commented Dec 2, 2023

srimanob commented Dec 2, 2023

antoniovilela commented Dec 4, 2023

jbsauvan commented Dec 4, 2023