Fix deprecated-copy warnings in MagneticField/ParametrizedEngine

[iarspider]

PR description:

Fix deprecated-copy warnings (rule-of-three violation) in MagneticField/ParametrizedEngine:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/MagneticField/ParametrizedEngine/src/rz_harm_poly.cc: In static member function 'static void magfieldparam::rz_harm_poly::SetTrigArrSize(unsigned int)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/MagneticField/ParametrizedEngine/src/rz_harm_poly.cc:108:32: warning: implicitly-declared 'constexpr magfieldparam::trig_pair& magfieldparam::trig_pair::operator=(const magfieldparam::trig_pair&)' is deprecated [-Wdeprecated-copy]
   108 |   (*TrigArr) = trig_pair(1., 0.);
      |                                ^
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/MagneticField/ParametrizedEngine/src/rz_harm_poly.cc:2:
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/MagneticField/ParametrizedEngine/src/rz_harm_poly.h:20:5: note: because 'magfieldparam::trig_pair' has user-provided 'magfieldparam::trig_pair::trig_pair(const magfieldparam::trig_pair&)'
   20 |     trig_pair(const trig_pair &tp) : CosPhi(tp.CosPhi), SinPhi(tp.SinPhi) {}
      |     ^~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/MagneticField/ParametrizedEngine/src/rz_harm_poly.cc: In static member function 'static void magfieldparam::rz_harm_poly::FillTrigArr(double)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/MagneticField/ParametrizedEngine/src/rz_harm_poly.cc:119:16: warning: implicitly-declared 'constexpr magfieldparam::trig_pair& magfieldparam::trig_pair::operator=(const magfieldparam::trig_pair&)' is deprecated [-Wdeprecated-copy]
   119 |   TrigArr[1] = tp;
      |                ^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/MagneticField/ParametrizedEngine/src/rz_harm_poly.h:20:5: note: because 'magfieldparam::trig_pair' has user-provided 'magfieldparam::trig_pair::trig_pair(const magfieldparam::trig_pair&)'
   20 |     trig_pair(const trig_pair &tp) : CosPhi(tp.CosPhi), SinPhi(tp.SinPhi) {}
      |     ^~~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/MagneticField/ParametrizedEngine/src/rz_harm_poly.cc:121:41: warning: implicitly-declared 'constexpr magfieldparam::trig_pair& magfieldparam::trig_pair::operator=(const magfieldparam::trig_pair&)' is deprecated [-Wdeprecated-copy]
   121 |     TrigArr[jp] = TrigArr[jp - 1].Add(tp);
      |                                         ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/36ee15c53d3074956fb6548fe912a5bd/opt/cmssw/el8_amd64_gcc12/cms/cmssw/CMSSW_14_0_DEVEL_X_2023-11-26-2300/src/MagneticField/ParametrizedEngine/src/rz_harm_poly.h:20:5: note: because 'magfieldparam::trig_pair' has user-provided 'magfieldparam::trig_pair::trig_pair(const magfieldparam::trig_pair&)'
   20 |     trig_pair(const trig_pair &tp) : CosPhi(tp.CosPhi), SinPhi(tp.SinPhi) {}
      |     ^~~~~~~~~

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[iarspider]

please test for CMSSW_14_0_DEVEL_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43399/37899

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• MagneticField/ParametrizedEngine (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@namapane this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec007e/36085/summary.html
COMMIT: 134da5e
CMSSW: CMSSW_14_0_X_2023-11-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43399/36085/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 436 lines to the logs
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3367918
• DQMHistoTests: Total failures: 1112
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3366784
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1