Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tau decay products in NanoDQM #43384

Conversation

Ksavva1021
Copy link
Contributor

PR description:

This PR adds tau decay product information in NanoAOD. A collection of tau decay products is created on the fly and then stored in a new NanoAOD table. Additional information stored is as follows for each candidate in the table:

  • 3-momenta
  • PDG ID
  • Index of its mother tau

Size tests have been conducted to assess the size increase on NanoAOD. These tests have been conducted using two RelVal samples:

  • TTBar (/w PU)
  • ZTT

The cumulative contribution of the tau decay products in NanoAOD is expected to be around 1.3 % (TTBar) and 2% (ZTT). Breakdowns are available here.

This PR also allows the tau decay products to be monitored by NanoDQM.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of PRs #42987 & #43382

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Ksavva1021 (Klitos Savva) for CMSSW_13_2_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen, @vlimant, @simonepigazzini can you please review it and eventually sign? Thanks.
@seemasharmafnal, @mbluj, @emilbols, @demuller, @JyothsnaKomaragiri, @hatakeyamak, @AlexDeMoor, @andrzejnovak, @ahinzmann, @gkasieczka, @Ming-Yan, @gouskos, @gpetruc, @azotz, @mariadalfonso, @nhanvtran, @rappoccio, @Senphy, @jdamgov, @mmarionncern, @AnnikaStein, @jdolen, @schoef this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@Ksavva1021 Ksavva1021 changed the title Cmssw 13 2 x tau pog tau prods in nano dqm Tau decay products in NanoDQM Nov 24, 2023
@Ksavva1021
Copy link
Contributor Author

Adding @mbluj as a watcher

@vlimant
Copy link
Contributor

vlimant commented Dec 1, 2023

enable nano

@vlimant
Copy link
Contributor

vlimant commented Dec 1, 2023

this backport to 13.2 does not seem necessary to me, unless this was already in 13.0.X

@mbluj
Copy link
Contributor

mbluj commented Dec 1, 2023

this backport to 13.2 does not seem necessary to me, unless this was already in 13.0.X

No, it was not in 13_0. We just wonder which release is going to be used for nano v12 as we would like to have this development in it.

@mandrenguyen
Copy link
Contributor

unassign reconstruction
since it only relates to nano, this is xpog business

@mandrenguyen
Copy link
Contributor

+reconstruction
Not sure why unassigned didn't work, so I'll just sign

@vlimant
Copy link
Contributor

vlimant commented Dec 4, 2023

please test

@vlimant
Copy link
Contributor

vlimant commented Dec 4, 2023

v12 is with 13.0 and is closed. if this goes in 13.3, then it will be in the upcoming v13

@mbluj
Copy link
Contributor

mbluj commented Dec 4, 2023

v12 is with 13.0 and is closed. if this goes in 13.3, then it will be in the upcoming v13

Yes, right. It was mistype, I meant v13... So, indeed there is not need to backport to 13_2

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-48e7fc/36313/summary.html
COMMIT: f2e1320
CMSSW: CMSSW_13_2_X_2023-12-04-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43384/36313/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198757
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 12.239999999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1.360 KiB Physics/NanoAODDQM
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 15841
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 15841
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19.039999999999996 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 1.360 KiB Physics/NanoAODDQM
  • Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.483 2.454 0.029 ( +1.2% ) 5.38 5.36 +0.4% 2.089 2.113
2500.001 2.629 2.588 0.041 ( +1.6% ) 4.84 4.81 +0.7% 2.117 2.546
2500.002 2.538 2.507 0.031 ( +1.2% ) 5.01 5.04 -0.5% 2.137 2.520
2500.01 1.271 1.252 0.019 ( +1.5% ) 10.02 9.90 +1.2% 2.227 2.232
2500.011 1.642 1.620 0.023 ( +1.4% ) 5.34 5.39 -0.8% 2.039 2.427
2500.012 1.522 1.501 0.020 ( +1.4% ) 7.56 7.81 -3.1% 1.916 2.334
2500.1 2.198 2.169 0.029 ( +1.3% ) 5.45 5.44 +0.2% 1.955 1.970
2500.2 2.309 2.280 0.029 ( +1.3% ) 6.28 6.29 -0.2% 1.840 1.884
2500.21 1.184 1.162 0.022 ( +1.9% ) 4.47 4.44 +0.7% 1.850 2.174
2500.211 1.545 1.520 0.025 ( +1.6% ) 3.84 3.90 -1.6% 1.947 2.254
2500.3 2.063 2.037 0.025 ( +1.2% ) 13.49 13.80 -2.2% 1.859 1.858
2500.31 1.258 1.237 0.021 ( +1.7% ) 20.69 21.82 -5.2% 2.227 2.260
2500.311 1.643 1.619 0.024 ( +1.5% ) 14.43 14.68 -1.7% 2.308 2.334
2500.4 2.063 2.037 0.025 ( +1.2% ) 13.45 13.87 -3.0% 1.861 1.856

@vlimant
Copy link
Contributor

vlimant commented Dec 11, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6cf29e0 into cms-sw:CMSSW_13_2_X Dec 11, 2023
12 checks passed
@vlimant
Copy link
Contributor

vlimant commented May 6, 2024

type tau

@cmsbuild cmsbuild added the tau label May 6, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

cms-bot internal usage

@mbluj mbluj deleted the CMSSW_13_2_X_tau-pog_tauProdsInNano_DQM branch September 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants