-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hash_name
function for RelMon utilities
#43348
Conversation
1. Compatibility issue with Python 3: Encode the `file_name` argument before computing the hash. 2. Import the `hashlib` module for the development environment
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43348/37811
|
A new Pull Request was created by @ggonzr (Geovanny González-Rodríguez) for master. It involves the following packages:
@syuvivida, @cmsbuild, @antoniovagnerini, @tjavaid, @nothingface0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cef693/35998/summary.html Comparison SummarySummary:
|
@ggonzr , can this update cause (though very minute i.e. a couple of entries) differences for the WF |
Hello @tjavaid, |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fixes a compatibility bug between Python 2 and 3 for RelMon HTML report generation. If the parameter
--hash_name
is set when usingValidationMatrix.py
, the scripts fails because it is required to encode the parameterfile_name
to be hashed asbytes
.str
is not longer supported.PR validation:
Some manual tests:
hash_name
) into another script and use it to hash some strings calling the script using the Python 2.7 and Python 3.11 interpreters.ValidationMatrix.py -R DQM_V0001_R000000001__RelValBuMixing_14__CMSSW_12_4_0-124X_mcRun3_2022_realistic_v5-v1__DQMIO.root -T DQM_V0001_R000000001__RelValBuMixing_14__CMSSW_12_4_0-124X_mcRun3_2022_realistic_v5-v1__DQMIO.root -o Test_Report --hash_name --standalone