Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSSW_13_3_X backport] Add CaloIdL_MW seeded filter and split the legs of CaloIdL_TrackIdL_IsoVL filter on nanoAOD filterBits #43292

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

ikrommyd
Copy link
Contributor

PR description:

Same as PR #43247

Backport:

This PR is a backport of PR #43247. Backport is required for the production of NanoAODv13 from CMSSW_13.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iasonkrom (Iason Krommydas) for CMSSW_13_3_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@simonepigazzini, @cmsbuild, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@ikrommyd ikrommyd changed the title better filterbits for double electron triggers Add CaloIdL_MW seeded filter and split the legs of CaloIdL_TrackIdL_IsoVL filter on nanoAOD filterBits Nov 15, 2023
@ikrommyd ikrommyd changed the title Add CaloIdL_MW seeded filter and split the legs of CaloIdL_TrackIdL_IsoVL filter on nanoAOD filterBits [CMSSW_13_3_X backport] Add CaloIdL_MW seeded filter and split the legs of CaloIdL_TrackIdL_IsoVL filter on nanoAOD filterBits Nov 15, 2023
@RSalvatico
Copy link
Contributor

enable nano

@RSalvatico
Copy link
Contributor

please test

@RSalvatico
Copy link
Contributor

type egamma

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85bf41/35858/summary.html
COMMIT: ab30954
CMSSW: CMSSW_13_3_X_2023-11-15-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43292/35858/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 145 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363028
  • DQMHistoTests: Total failures: 2461
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3360545
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 154 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16335
  • DQMHistoTests: Total failures: 308
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16027
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.535 2.535 -0.000 ( -0.0% ) 5.28 5.33 -1.1% 2.139 2.152
2500.001 2.680 2.680 0.000 ( +0.0% ) 4.77 4.74 +0.6% 2.571 2.585
2500.002 2.616 2.616 0.000 ( +0.0% ) 4.92 4.94 -0.5% 2.573 2.558
2500.01 1.307 1.307 -0.001 ( -0.0% ) 9.95 9.96 -0.1% 2.265 2.269
2500.011 1.721 1.721 -0.000 ( -0.0% ) 5.36 5.30 +1.0% 2.458 2.456
2500.012 1.567 1.567 -0.000 ( -0.0% ) 7.68 7.70 -0.2% 2.358 2.362
2500.1 2.187 2.187 -0.000 ( -0.0% ) 5.42 5.35 +1.3% 2.005 2.000
2500.2 2.297 2.297 -0.000 ( -0.0% ) 6.17 6.15 +0.4% 1.917 1.920
2500.21 1.174 1.174 0.000 ( +0.0% ) 4.47 4.40 +1.5% 2.214 2.216
2500.211 1.535 1.535 0.000 ( +0.0% ) 3.84 3.88 -1.0% 2.297 2.297
2500.3 2.052 2.053 -0.001 ( -0.0% ) 12.96 13.03 -0.6% 1.896 1.901
2500.31 1.248 1.248 -0.000 ( -0.0% ) 21.06 20.59 +2.3% 2.303 2.306
2500.311 1.634 1.634 0.000 ( +0.0% ) 14.59 14.34 +1.7% 2.376 2.389
2500.4 2.052 2.053 -0.001 ( -0.0% ) 13.04 13.03 +0.0% 1.903 1.905
2500.5 19.544 19.544 0.000 ( +0.0% ) 1.40 1.47 -5.0% 1.315 1.314

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cc03893 into cms-sw:CMSSW_13_3_X Nov 17, 2023
@ikrommyd ikrommyd deleted the electron-trigobj-filterbits branch November 17, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants