Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Vertex smearing for PbPb MC based on 2023 PbPb data #43290

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Verbatim backport of #43217
See master PR for detailed description

PR validation:

See master PR

Backport:

Backport of #43217

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2023

A new Pull Request was created by @francescobrivio for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)

@cmsbuild, @fabiocos, @mdhildreth, @rappoccio, @civanch, @antoniovilela, @davidlange6 can you please review it and eventually sign? Thanks.
@sameasy, @Martin-Grunewald, @GiacomoSguazzoni, @mtosi, @missirol, @felicepantaleo, @VinInn, @mmusich, @dgulhan, @grzanka, @VourMa, @JanFSchulte, @rovere, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

backport of #43217

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

  • even though nothing is really consuming this for now AFAIU

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-57bd4e/35846/summary.html
COMMIT: 4e41ddd
CMSSW: CMSSW_13_0_X_2023-11-12-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43290/35846/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 186 lines from the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283598
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Nov 16, 2023

+1

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit edb6a85 into cms-sw:CMSSW_13_0_X Nov 20, 2023
@francescobrivio francescobrivio deleted the HI_2023_VtxSmearing_13_0_X branch November 20, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants