Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Vertex smearing for PbPb MC based on 2023 PbPb data #43288

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Verbatim backport of #43217
See master PR for detailed description

PR validation:

See master PR

Backport:

Backport of #43217

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2023

A new Pull Request was created by @francescobrivio for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)

@fabiocos, @civanch, @rappoccio, @cmsbuild, @mdhildreth, @antoniovilela, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @fabiocos, @GiacomoSguazzoni, @missirol, @rovere, @JanFSchulte, @makortel, @grzanka, @mmusich, @VourMa, @Martin-Grunewald, @VinInn, @dgulhan, @sameasy, @mtosi, @slomeo this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

backport of #43217

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

  • even though nothing is really consuming this for now AFAIU

@mmusich
Copy link
Contributor

mmusich commented Nov 15, 2023

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c62917/35848/summary.html
COMMIT: e5c8666
CMSSW: CMSSW_13_2_X_2023-11-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43288/35848/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198758
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

@cms-sw/simulation-l2
Please check and sign.
Thanks.

@civanch
Copy link
Contributor

civanch commented Nov 16, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 5772b7a into cms-sw:CMSSW_13_2_X Nov 16, 2023
@ashleyahram
Copy link

Dear @antoniovilela,

Can I ask a new release so that we can produce a relval MC sample using CSMSW_13_2_X with the implemented PR. We are waiting for it to produce MC described in this JIRA ticket (PDMVRELVALS-223)

Thank you,
Saeahram

@francescobrivio francescobrivio deleted the HI_2023_VtxSmearing_13_2_X branch November 20, 2023 14:48
@rappoccio rappoccio mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants