Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X SIM] Allowed MT mode for RHStopTracer of R-hadron simulation #43273

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Nov 14, 2023

PR description:

RHStopTracer is implemented as a SimProducer wrapper allowing identify stop of R-hadrons within CMS.
In this PR this wrapper is enabled for the MT mode.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

when will approved will be backported to Run3 MC production releases.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43273/37678

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43273/37679

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

  • SimG4Core/CustomPhysics (simulation)

@civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@slomeo, @makortel, @bsunanda, @fabiocos, @rovere this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Nov 14, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-891ab4/35809/summary.html
COMMIT: 1c0e386
CMSSW: CMSSW_14_0_X_2023-11-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43273/35809/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363028
  • DQMHistoTests: Total failures: 1400
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361606
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor Author

civanch commented Nov 15, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@civanch civanch changed the title [14_0_X SIM] Allowed MT mode for RHStopTracer [14_0_X SIM] Allowed MT mode for RHStopTracer of R-hadron simulation Nov 15, 2023
@tvami
Copy link
Contributor

tvami commented Nov 15, 2023

urgent

  • @cms-sw/orp-l2 we need the backport of this for Run-3 signal simulations, please merge asap, thanks!

@tvami
Copy link
Contributor

tvami commented Nov 15, 2023

I validated with

cmsrel CMSSW_14_0_X_2023-11-15-1100
cd CMSSW_14_0_X_2023-11-15-1100/src
cmsenv
git cms-merge-topic 43273
curl -s -k https://cms-pdmv-prod.web.cern.ch/mcm/public/restapi/requests/get_fragment/PPD-Run3Summer22HSCPGS-00002 --retry 3 --create-dirs -o Configuration/GenProduction/python/PPD-Run3Summer22HSCPGS-00002-fragment.py -s Configuration/GenProduction/python/PPD-Run3Summer22HSCPGS-00002-fragment.py
scram b -j
cmsDriver.py Configuration/GenProduction/python/PPD-Run3Summer22HSCPGS-00002-fragment.py --python_filename PPD-Run3Summer22HSCPGS-00002_1_cfg.py --eventcontent RAWSIM --customise SimG4Core/CustomPhysics/Exotica_HSCP_SIM_cfi.customise,Configuration/DataProcessing/Utils.addMonitoring --datatier GEN-SIM --fileout file:PPD-Run3Summer22HSCPGS-00002.root --conditions 124X_mcRun3_2022_realistic_v12 --beamspot Realistic25ns13p6TeVEarly2022Collision --customise_commands process.source.numberEventsInLuminosityBlock="cms.untracked.uint32(100)" --step GEN,SIM --geometry DB:Extended --era Run3 --mc -n 10  --nThread=2

it works fine! (As opposed to w/o the PR we get

RunManagerMTWorker::createWatchers: Unable to use Watcher RHStopTracer if number of threads > 1
----- End Fatal Exception -------------------------------------------------

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants