Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert decrease of precision introduced in ea3f693d #43254

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Revert decrease of precision introduced in ea3f693d #43254

merged 1 commit into from
Nov 17, 2023

Conversation

maxgalli
Copy link
Contributor

Backport to 13_3_X of #43253

@cmsbuild cmsbuild added this to the CMSSW_13_3_X milestone Nov 13, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2023 •
edited
Loading

A new Pull Request was created by @maxgalli (Massimiliano Galli) for CMSSW_13_3_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @simonepigazzini, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@simonepigazzini
Copy link
Contributor

enable nano

@simonepigazzini
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f189c/35767/summary.html
COMMIT: 4295b95
CMSSW: CMSSW_13_3_X_2023-11-13-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43254/35767/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 100 lines from the logs
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363010
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3362942
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 90 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16314
  • DQMHistoTests: Total failures: 147
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16167
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.535 2.531 0.005 ( +0.2% ) 5.31 5.33 -0.2% 2.103 2.128
2500.001 2.680 2.677 0.003 ( +0.1% ) 4.76 4.78 -0.5% 2.133 2.552
2500.002 2.616 2.611 0.006 ( +0.2% ) 5.00 4.94 +1.1% 2.132 2.541
2500.01 1.307 1.304 0.003 ( +0.3% ) 9.99 9.98 +0.1% 2.202 2.242
2500.011 1.721 1.717 0.005 ( +0.3% ) 5.35 5.34 +0.1% 2.005 2.426
2500.012 1.567 1.564 0.003 ( +0.2% ) 7.62 7.67 -0.7% 2.032 2.342
2500.1 2.187 2.183 0.004 ( +0.2% ) 5.39 5.38 +0.3% 1.966 1.979
2500.2 2.298 2.294 0.004 ( +0.2% ) 6.19 6.16 +0.5% 1.847 1.897
2500.21 1.174 1.170 0.004 ( +0.3% ) 4.43 4.43 +0.0% 1.870 2.198
2500.211 1.535 1.531 0.004 ( +0.3% ) 3.85 3.88 -0.8% 1.969 2.276
2500.3 2.053 2.050 0.003 ( +0.1% ) 13.12 12.99 +1.0% 1.883 1.885
2500.31 1.249 1.245 0.003 ( +0.3% ) 20.62 20.91 -1.4% 2.250 2.284
2500.311 1.635 1.631 0.004 ( +0.2% ) 13.94 14.37 -3.0% 2.330 2.356
2500.4 2.053 2.050 0.003 ( +0.1% ) 12.99 12.99 -0.0% 1.882 1.887
2500.5 19.544 19.544 0.000 ( +0.0% ) 1.39 1.22 +14.4% 1.288 1.294

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@maxgalli maxgalli force-pushed the revert_ss_precision_13_3_x branch from 4295b95 to 9459bcb Compare November 15, 2023 09:01
@cmsbuild
Copy link
Contributor

Pull request #43254 was updated. @simonepigazzini, @vlimant, @cmsbuild can you please check and sign again.

@simonepigazzini
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f189c/35831/summary.html
COMMIT: 9459bcb
CMSSW: CMSSW_13_3_X_2023-11-14-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43254/35831/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 110 lines to the logs
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363028
  • DQMHistoTests: Total failures: 1435
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3361571
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 90 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16335
  • DQMHistoTests: Total failures: 147
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16188
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.539 2.535 0.004 ( +0.1% ) 5.21 5.24 -0.5% 2.076 2.005
2500.001 2.685 2.680 0.005 ( +0.2% ) 4.72 4.72 +0.0% 2.504 2.023
2500.002 2.621 2.616 0.005 ( +0.2% ) 4.85 4.94 -1.8% 2.504 2.023
2500.01 1.311 1.307 0.003 ( +0.3% ) 9.75 9.63 +1.2% 2.188 2.104
2500.011 1.726 1.721 0.005 ( +0.3% ) 5.21 5.15 +1.1% 2.318 1.884
2500.012 1.572 1.567 0.004 ( +0.3% ) 7.47 7.44 +0.5% 2.215 1.860
2500.1 2.190 2.187 0.003 ( +0.1% ) 5.40 5.37 +0.5% 1.939 1.869
2500.2 2.301 2.297 0.003 ( +0.1% ) 6.17 6.11 +0.9% 1.837 1.744
2500.21 1.177 1.174 0.003 ( +0.3% ) 4.43 4.38 +1.2% 2.150 1.784
2500.211 1.539 1.535 0.004 ( +0.3% ) 3.88 3.84 +1.2% 2.160 1.872
2500.3 2.057 2.053 0.004 ( +0.2% ) 13.07 12.95 +1.0% 1.900 1.807
2500.31 1.252 1.248 0.004 ( +0.3% ) 20.80 20.63 +0.9% 2.277 2.272
2500.311 1.638 1.634 0.004 ( +0.2% ) 14.52 14.24 +1.9% 2.244 2.242
2500.4 2.057 2.053 0.004 ( +0.2% ) 12.93 13.12 -1.4% 1.904 1.903
2500.5 19.544 19.544 0.000 ( +0.0% ) 1.46 1.32 +11.1% 1.314 1.311

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

backport of #43253

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 09846b5 into cms-sw:CMSSW_13_3_X Nov 17, 2023
@rappoccio rappoccio mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed orp-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_13_3_X
Development

Successfully merging this pull request may close these issues.
4 participants
@maxgalli @cmsbuild @simonepigazzini @antoniovilela