Implement ROOT read rules for PortableHostCollection [13.3.x]

[fwyzard]

PR description:

Implement ROOT read rules for PortableHostCollection instantiations.

These replace the user-defined read rules in the XML file

  <read
    sourceClass="portabletest::TestHostCollection"
    targetClass="portabletest::TestHostCollection"
    version="[1-]"
    source="portabletest::TestSoA layout_;"
    target="buffer_,layout_,view_"
    embed="false">
  <![CDATA[
    portabletest::TestHostCollection::ROOTReadStreamer(newObj, onfile.layout_);
  ]]>
  </read>

with a macro-based C++ implementation in DataFormats/PortableTestObjects/src/classes.cc:

#include "DataFormats/Portable/interface/PortableHostCollectionReadRules.h"
#include "DataFormats/PortableTestObjects/interface/TestHostCollection.h"

SET_PORTABLEHOSTCOLLECTION_READ_RULES(portabletest::TestHostCollection);

PR validation:

The HeterogeneousCore/AlpakaTest/test/testHeterogeneousCoreAlpakaTestWriteRead.sh unit test pass:

• the portabletest::TestHostCollection is written to a ROOT file;
• it is read back from the ROOT file using the user-defined streamer function;
• the validation checks pass.

If this PR is a backport please specify the original PR and why you need to backport that PR.

Backport of #43219 to CMSSW_13_3_X.

[fwyzard]

backport #43219

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_13_3_X.

It involves the following packages:

• DataFormats/Portable (heterogeneous)
• DataFormats/PortableTestObjects (heterogeneous)

@fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Implement ROOT read rules for PortableHostCollection #43219

[fwyzard]

+heterogeneous

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0aa7bc/35732/summary.html
COMMIT: ceab451
CMSSW: CMSSW_13_3_X_2023-11-09-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43241/35732/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 9 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362985
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 931
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 38809
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[rappoccio]

+1