L1T Seeded Cone jets update

[thesps]

In the context of phase 2 L1T emulation, this PR:

• introduces the R=0.8 configuration for Seeded Cone jets (SC8)
• renames existing Seeded Cone jet collections to 'SC4' for consistency
• fixes some issues with bit-exact matching of the emulator wrt the firmware particularly for MHT
• makes the jets/sums pattern file writer more flexible for testing against the firmware with different configurations (configurable input collections of jets and sums)

For testing, this CMSSW emulator now matches the firmware tested on an L1T board at the level of 99.9% for jets and 95% for sums (100% on the scalar sum and 95% on the vector sum due a difference in libraries for the trigonometry [std math vs hls math]).

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43233/37588

• This PR adds an extra 44KB to repository

• Found files with invalid states:

  • L1Trigger/Phase2L1ParticleFlow/python/l1ctJetFileWriter_cfi.py:
    • Added: 92ea3ea
    • Modified: 498ed94, 8570d4f
    • Deleted: 3cbf8e9

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43233/37588/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43233/37588/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43233/37676

• This PR adds an extra 64KB to repository

• Found files with invalid states:

  • L1Trigger/Phase2L1ParticleFlow/python/l1ctJetFileWriter_cfi.py:
    • Added: 92ea3ea
    • Modified: 498ed94, 8570d4f
    • Deleted: 3cbf8e9

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24393d/36614/summary.html
COMMIT: 4bb3750
CMSSW: CMSSW_14_0_X_2023-12-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43233/36614/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 1219
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246036
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

@epalencia I think I'm satisfied with this, we reviewed it in the L1 fork. Anything from your side?

[epalencia]

+l1

[epalencia]

ping @cms-sw/upgrade-l2

[srimanob]

@cmsbuild please test

Just to trigger the test after a month.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24393d/36916/summary.html
COMMIT: 4bb3750
CMSSW: CMSSW_14_0_X_2024-01-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43233/36916/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247526
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247501
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[subirsarkar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1