-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.3.X] migrate JetMETDQMDCSFilter
to use DSCRecord
#43230
[13.3.X] migrate JetMETDQMDCSFilter
to use DSCRecord
#43230
Conversation
…ilable (>= Run3 case)
type bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X. It involves the following packages:
@tjavaid, @rvenditti, @syuvivida, @antoniovagnerini, @nothingface0, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d328d2/35711/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #43137
PR description:
I noticed that this class
JetMETDQMDCSFilter
used in the JME DQM atcmssw/DQMOffline/JetMET/src/JetAnalyzer.cc
Line 2478 in a05e5a4
was not migrated to use the
DCSRecord
from s/w FED instead of theDCSStatus
from scalers.Since when SCAL was decomissoned at the beginning of Run 3, this is probably causing the have LS in which part of the detector is off to be accepted.
PR validation:
cmssw
compiles. Also runrunTheMatrix.py -l limited --ibeos
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #43137, proposing to 13.3.X because it still merges seamlessly and it's a low hanging fruit.