Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.3.X] migrate JetMETDQMDCSFilter to use DSCRecord #43230

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 9, 2023

backport of #43137

PR description:

I noticed that this class JetMETDQMDCSFilter used in the JME DQM at

bool dcsDecision = DCSFilterForJetMonitoring_->filter(iEvent, iSetup);

was not migrated to use the DCSRecord from s/w FED instead of the DCSStatus from scalers.
Since when SCAL was decomissoned at the beginning of Run 3, this is probably causing the have LS in which part of the detector is off to be accepted.

PR validation:

cmssw compiles. Also run runTheMatrix.py -l limited --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #43137, proposing to 13.3.X because it still merges seamlessly and it's a low hanging fruit.

@mmusich
Copy link
Contributor Author

mmusich commented Nov 9, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_3_X.

It involves the following packages:

  • DQMOffline/JetMET (dqm)

@tjavaid, @rvenditti, @syuvivida, @antoniovagnerini, @nothingface0, @cmsbuild can you please review it and eventually sign? Thanks.
@seemasharmafnal, @jdamgov, @nhanvtran, @jdolen, @mmarionncern, @gkasieczka, @schoef, @rappoccio, @ahinzmann, @rociovilar, @mariadalfonso this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 9, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d328d2/35711/summary.html
COMMIT: 49f9941
CMSSW: CMSSW_13_3_X_2023-11-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43230/35711/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 616 lines to the logs
  • Reco comparison results: 136 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363010
  • DQMHistoTests: Total failures: 2527
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3360461
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Nov 9, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fb662aa into cms-sw:CMSSW_13_3_X Nov 13, 2023
@mmusich mmusich deleted the mm_dev_migrateJetMETDQMDCSFiltertoDSCRecord branch November 13, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants