Phase2-hgx348B Take care of handling both HGCal and HFNose access to Geometry and Topology classes

[bsunanda]

PR description:

Take care of handling both HGCal and HFNose access to Geometry and Topology classes. Takes care of invalid. DetId issue for the workflow 23234.0

PR validation:

Tested using the workflow 23234.0 in debug mode

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not special. Maybe the bug fix to be back ported for some earlier release which needs phase2 23234.0 for validation

[bsunanda]

type Bugfix

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43194/37512

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43194/37512/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43194/37512/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43194/37513

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/CaloTopology (geometry)
• Geometry/HGCalGeometry (geometry, upgrade)

@srimanob, @AdrianoDee, @civanch, @mdhildreth, @cmsbuild, @Dr15Jones, @makortel, @bsunanda can you please review it and eventually sign? Thanks.
@ReyerBand, @thomreis, @fabiocos, @wang0jin this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e4297/35612/summary.html
COMMIT: 22b5a7b
CMSSW: CMSSW_13_3_X_2023-11-05-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43194/35612/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 450 lines from the logs
• Reco comparison results: 136 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363010
• DQMHistoTests: Total failures: 2390
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3360598
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

regression problems only in MkFit WF

[bsunanda]

@srimanob Please approve this

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1