Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-sim150 Update the scripts in SimG4Core/PrintGeomInfo #43178

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Nov 3, 2023

PR description:

Update the scripts in SimG4Core/PrintGeomInfo.

PR validation:

Ran the scripts and verified overlaps in all new Phase2 scenarios- none in DD4hep part and only those old 36 overlaps among the EB supermodules in the DDD part

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43178/37508

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • SimG4Core/PrintGeomInfo (simulation)

@civanch, @cmsbuild, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @slomeo, @fabiocos this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 3, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d05781/35580/summary.html
COMMIT: 01358ea
CMSSW: CMSSW_13_3_X_2023-11-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43178/35580/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 132 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3362691
  • DQMHistoTests: Total failures: 1785
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3360884
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Nov 3, 2023

+1

Regression is a problem for MkFit WF - not due to this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ba2c993 into cms-sw:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants