Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7_1_X] Fix EmissionVetoHook for BB4L #43173

Merged

Conversation

lauridsj
Copy link
Contributor

@lauridsj lauridsj commented Nov 2, 2023

PR description:

This is a backport of #42264, fixing the Pythia EmissionVetoHook for BB4L, to CMSSW 7_1_X. This is needed for the ttbar spin entanglement analysis, which uses preLegacy 2016 data. For this analysis, a sample with the Powheg process "ttb_NLO_dec" is needed for a cross-check. This process has the same final state as BB4L (up to three real emissions) and thus uses the same hook.

PR validation:

See #42264.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42264, as written above.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

A new Pull Request was created by @lauridsj (Laurids Jeppe) for CMSSW_7_1_X.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@mkirsano, @alberto-sanchez, @bbilin, @GurpreetSinghChahal, @SiewYan, @menglu21, @cmsbuild can you please review it and eventually sign? Thanks.
@mkirsano, @alberto-sanchez this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@bbilin
Copy link
Contributor

bbilin commented Nov 3, 2023

@cmsbuild please test

@agrohsje
Copy link

agrohsje commented Nov 3, 2023

hi @RSalvatico @perrotta , can you advise on how to solve the missing IB problem? thanks.

@perrotta
Copy link
Contributor

perrotta commented Nov 3, 2023

hi @RSalvatico @perrotta , can you advise on how to solve the missing IB problem? thanks.

Maybe @smuzaffar can create a 7_1_X IB only for this purpose.
Or maybe the release managers (@rappoccio and @antoniovilela ) can decide to merge this simple PR without testing it, possibly after it will have been discussed in a ORP meeting.

@smuzaffar
Copy link
Contributor

smuzaffar commented Nov 3, 2023

I need to enable add 7.1.X IBs otherwise you will not be able to build the release.
I will get back to you once 7.1.X IBs are available.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e77c43/35582/summary.html
COMMIT: 793c53d
CMSSW: CMSSW_7_1_X_2023-11-03-1100/slc6_amd64_gcc481
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43173/35582/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 4.224.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
  • 25202.0
----- Begin Fatal Exception 03-Nov-2023 17:34:17 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

AddOn Tests

----- Begin Fatal Exception 03-Nov-2023 17:27:54 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/relval/CMSSW_7_1_0_pre9/RelValProdTTbar/AODSIM/START71_V5-v1/00000/F4F6CBF6-8AF0-E311-8AEF-003048678ED2.root'
   Additional Info:
      [a] Input file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_7_1_0_pre9/RelValProdTTbar/AODSIM/START71_V5-v1/00000/F4F6CBF6-8AF0-E311-8AEF-003048678ED2.root could not be opened.
Fallback Input file root://cms-xrd-global.cern.ch//store/relval/CMSSW_7_1_0_pre9/RelValProdTTbar/AODSIM/START71_V5-v1/00000/F4F6CBF6-8AF0-E311-8AEF-003048678ED2.root also could not be opened.
      [b] XrdClient::Open(name='root://cms-xrd-global.cern.ch//store/relval/CMSSW_7_1_0_pre9/RelValProdTTbar/AODSIM/START71_V5-v1/00000/F4F6CBF6-8AF0-E311-8AEF-003048678ED2.root', flags=0x10, permissions=0666) => error 'No servers are available to read the file.' (errno=3011)
      [c] Current server connection: root://cms-xrd-transit.cern.ch:1094//store/relval/CMSSW_7_1_0_pre9/RelValProdTTbar/AODSIM/START71_V5-v1/00000/F4F6CBF6-8AF0-E311-8AEF-003048678ED2.root
----- End Fatal Exception -------------------------------------------------

@agrohsje
Copy link

agrohsje commented Nov 6, 2023

Dear @smuzaffar , how should we proceed with the problems above? Thanks, Alexander.

@smuzaffar
Copy link
Contributor

@agrohsje , tests are failing for 7.1.X IBs , I think data for wf 4.22 is still available but wf 25202.0 data (/RelValTTbar_13/CMSSW_7_1_14-MCRUN2_71_V1-v1/GEN-SIM) is not available ( das client does not return any thing for this).

I would suggest to ignore the tests results here

@agrohsje
Copy link

agrohsje commented Nov 6, 2023

Thanks! @menglu21 @bbilin Please check and sign. Thanks!

@menglu21
Copy link
Contributor

menglu21 commented Nov 6, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@agrohsje
Copy link

agrohsje commented Nov 6, 2023

Dear @RSalvatico, can we get a new 7_1 release? We need them urgently for some pre-legcay 2016 top pag analysis.

@RSalvatico
Copy link
Contributor

Dear @RSalvatico, can we get a new 7_1 release? We need them urgently for some pre-legcay 2016 top pag analysis.

Hello, I'm afraid you are tagging the wrong person :) Though I am not sure who you meant to ping, so I cannot forward the ping myself.

Riccardo Salvatico

@agrohsje
Copy link

agrohsje commented Nov 6, 2023

Sorry for the wrong tag. My mistake. I wanted to ping @rappoccio @antoniovilela:
Can we get a new 7_1 release? We need them urgently for some pre-legcay 2016 top pag analysis.

@rappoccio
Copy link
Contributor

@smuzaffar Is it possible to even build this release? @jordan-martins and @malbouis are checking if there are even pileup libraries available to do this.

@agrohsje we usually reserve "urgent" for datataking issues, a pre-legacy 2016 MC sample is not really what we would refer to as "urgent".

@smuzaffar
Copy link
Contributor

yes @rappoccio , bot is able to build the IB so it should be able to build the release

@agrohsje
Copy link

agrohsje commented Nov 7, 2023

Hi @rappoccio. The analysis is the answer from CMS on the entanglement observation of ATLAS. Target here is end of November, hence the time pressure and the increased priority. If this is technically still possible, having 2 more samples in 7_1 with the bug fix above would be of great help. Let me know.

@antoniovilela
Copy link
Contributor

Hi @rappoccio. The analysis is the answer from CMS on the entanglement observation of ATLAS. Target here is end of November, hence the time pressure and the increased priority. If this is technically still possible, having 2 more samples in 7_1 with the bug fix above would be of great help. Let me know.

Hi @agrohsje, we will merge it and attempt to build the release later this week. If needed more urgently than this (we have a queue of releases to be built), please go through PPD to pass along the request.

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 17cafb5 into cms-sw:CMSSW_7_1_X Nov 7, 2023
@agrohsje
Copy link

agrohsje commented Nov 9, 2023

Thanks for 7_1_48! Just saw the announcement. Really great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants