-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 7_1_X] Fix EmissionVetoHook for BB4L #43173
[Backport 7_1_X] Fix EmissionVetoHook for BB4L #43173
Conversation
A new Pull Request was created by @lauridsj (Laurids Jeppe) for CMSSW_7_1_X. It involves the following packages:
@mkirsano, @alberto-sanchez, @bbilin, @GurpreetSinghChahal, @SiewYan, @menglu21, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
hi @RSalvatico @perrotta , can you advise on how to solve the missing IB problem? thanks. |
Maybe @smuzaffar can create a 7_1_X IB only for this purpose. |
I need to enable add 7.1.X IBs otherwise you will not be able to build the release. |
please test |
-1 Failed Tests: RelVals AddOn RelVals
AddOn Tests
|
Dear @smuzaffar , how should we proceed with the problems above? Thanks, Alexander. |
@agrohsje , tests are failing for 7.1.X IBs , I think data for wf 4.22 is still available but wf 25202.0 data ( I would suggest to ignore the tests results here |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Dear @RSalvatico, can we get a new 7_1 release? We need them urgently for some pre-legcay 2016 top pag analysis. |
Hello, I'm afraid you are tagging the wrong person :) Though I am not sure who you meant to ping, so I cannot forward the ping myself. Riccardo Salvatico |
Sorry for the wrong tag. My mistake. I wanted to ping @rappoccio @antoniovilela: |
@smuzaffar Is it possible to even build this release? @jordan-martins and @malbouis are checking if there are even pileup libraries available to do this. @agrohsje we usually reserve "urgent" for datataking issues, a pre-legacy 2016 MC sample is not really what we would refer to as "urgent". |
yes @rappoccio , bot is able to build the IB so it should be able to build the release |
Hi @rappoccio. The analysis is the answer from CMS on the entanglement observation of ATLAS. Target here is end of November, hence the time pressure and the increased priority. If this is technically still possible, having 2 more samples in 7_1 with the bug fix above would be of great help. Let me know. |
Hi @agrohsje, we will merge it and attempt to build the release later this week. If needed more urgently than this (we have a queue of releases to be built), please go through PPD to pass along the request. |
+1 |
merge |
Thanks for 7_1_48! Just saw the announcement. Really great. |
PR description:
This is a backport of #42264, fixing the Pythia EmissionVetoHook for BB4L, to CMSSW 7_1_X. This is needed for the ttbar spin entanglement analysis, which uses preLegacy 2016 data. For this analysis, a sample with the Powheg process "ttb_NLO_dec" is needed for a cross-check. This process has the same final state as BB4L (up to three real emissions) and thus uses the same hook.
PR validation:
See #42264.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #42264, as written above.