Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SimBeamSpotObjects to handle different EvtVtxGenerators #43160

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Oct 31, 2023

PR description:

This PR aims at improving the SimBeamSpotObjects CondFormat in the context of cms-AlCaDB/AlCaTools#86.

Following the discussion in the same issue the decision is to:

  • Adapt the current SimBeamSpotObjects to be able to handle both Betafunc- and Gauss-EvtVtxGenerators, which are the two generators used up to Run 3 (for realistic and ideal BS conditions, respectively). This is done in commit 6d6fac2, specifically in this commit I have:
    • Adapted the SimBeamSpotObjects.hCondFormat
    • Updated the read and write tools in CondTools/BeamSpot (and relative unitTests)
    • Updated the PayloadInspector class (and relative unitTests)
    • Added to the GaussEvtVtxGenerator.h the possibility to read the VtxSmearing parameters from the DB
    • Created and uploaded all the new SimBeamSpotObjects single-IOV tags to the Prep CondDB

The next step is to introduce a new CondFormat (and relative utility scripts) to handle the HL-LHC BeamSpot case, this is why I'm opening this PR as draft for the moment.
To do:

  • Add new CondFormat for HL-LHC BeamSpot
  • Add write and read scripts with relative unitTests
  • Add PayloadInspector class
  • Update the HLLHCEvtVtxGenerator

For this second step it would be very helpful to receive feedback on the discussion at cms-AlCaDB/AlCaTools#86 (comment) from the original authors of the HLLHCEvtVtxGenerator module (FYI @lgray).

EDIT: it has been decided to leave this second step to a following PR.

PR validation:

This PR was validated by:

  • running (successfully) all the unitTests involved
  • generating PayloadInspector plots with:
getPayloadData.py \
   --plugin pluginSimBeamSpot_PayloadInspector \
   --plot plot_SimBeamSpotParameters \
   --tag SimBeamSpot_Realistic25ns13p6TeVEOY2022CollisionVtxSmearingParameters_v1_mc \
   --time_type Run \
   --iovs '{"start_iov": "1", "end_iov": "1"}' \
   --db Prep \
   --test

getPayloadData.py \
   --plugin pluginSimBeamSpot_PayloadInspector \
   --plot plot_SimBeamSpotParameters \
   --tag SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v1_mc \
   --time_type Run \
   --iovs '{"start_iov": "1", "end_iov": "1"}' \
   --db Prep \
   --test

getPayloadData.py \
   --plugin pluginSimBeamSpot_PayloadInspector \
   --plot plot_SimBeamSpotParametersDiffTwoTags \
   --tag SimBeamSpot_Realistic25ns13p6TeVEOY2022CollisionVtxSmearingParameters_v1_mc \
   --time_type Run \
   --iovs '{"start_iov": "1", "end_iov": "1"}' \
   --tagtwo SimBeamSpot_GaussVtxSigmaZ4cmSmearingParameters_v1_mc \
   --iovstwo '{"start_iov": "1", "end_iov": "1"}' \
   --db Prep \
   --test

Which result in the following plots:

Backport:

Not a backport, no backport is foreseen for the moment.

FYI @mmusich @dzuolo @lguzzi @gennai

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

  • since b9a4b4c should be self-consistent, we can start already testing it now

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43160/37467

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • CondCore/BeamSpotPlugins (db)
  • CondFormats/BeamSpotObjects (alca, db)
  • CondTools/BeamSpot (alca, db)
  • IOMC/EventVertexGenerators (simulation)

@perrotta, @saumyaphor4252, @mdhildreth, @francescobrivio, @civanch, @consuegs can you please review it and eventually sign? Thanks.
@PonIlya, @tocheng, @fabiocos, @rsreds, @mmusich, @grzanka, @seemasharmafnal, @yuanchao this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e0423/35538/summary.html
COMMIT: b9a4b4c
CMSSW: CMSSW_13_3_X_2023-10-31-1400/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43160/35538/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3362691
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3362666
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

Copy link
Contributor

@mmusich mmusich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @francescobrivio, I have a small suggestion (open to discussion)

CondFormats/BeamSpotObjects/interface/SimBeamSpotObjects.h Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43160/37475

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2023

Pull request #43160 was updated. @consuegs, @cmsbuild, @mdhildreth, @civanch, @saumyaphor4252, @francescobrivio, @perrotta can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

Pull request #43160 was updated. @mdhildreth, @francescobrivio, @cmsbuild, @saumyaphor4252, @civanch, @consuegs, @perrotta can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2023

please test

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2023

The next step is to introduce a new CondFormat (and relative utility scripts) to handle the HL-LHC BeamSpot case, this is why I'm opening this PR as draft for the moment.

in the interest of starting to have something usable for Run-3 simulation, I would defer this step to a later PR.

@francescobrivio
Copy link
Contributor Author

The next step is to introduce a new CondFormat (and relative utility scripts) to handle the HL-LHC BeamSpot case, this is why I'm opening this PR as draft for the moment.

in the interest of starting to have something usable for Run-3 simulation, I would defer this step to a later PR.

Ok as you prefer!
I have an almost ready commit, but we can go ahead with two different PRs, I'll mark this one as ready for review then!

@francescobrivio francescobrivio marked this pull request as ready for review November 2, 2023 17:33
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e0423/35566/summary.html
COMMIT: 6d6fac2
CMSSW: CMSSW_13_3_X_2023-11-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43160/35566/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 73 lines to the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3362691
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3362668
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

+db

@perrotta
Copy link
Contributor

perrotta commented Nov 3, 2023

+alca

@civanch
Copy link
Contributor

civanch commented Nov 3, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fbc695d into cms-sw:master Nov 3, 2023
@francescobrivio francescobrivio deleted the update_SimBeamSpotObjects branch November 20, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants