Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-LS Monitor Elements for Heavy Ions #43151

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

alpapana
Copy link

PR description:

Added per-LS MEs for Heavy Ions. "JetMET/HIJetValidation/akCs4PFJets/SumPFPt", "JetMET/HIJetValidation/akPu4CaloJets/SumPFPt".

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alpapana for CMSSW_13_2_X.

It involves the following packages:

  • DQMOffline/JetMET (dqm)
  • DQMServices/Core (dqm)

@nothingface0, @tjavaid, @syuvivida, @cmsbuild, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks.
@nhanvtran, @seemasharmafnal, @schoef, @mmarionncern, @rappoccio, @gkasieczka, @rociovilar, @ahinzmann, @jdamgov, @barvic, @jdolen, @mariadalfonso this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Oct 31, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf1740/35534/summary.html
COMMIT: 4e4eec7
CMSSW: CMSSW_13_2_X_2023-10-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43151/35534/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198760
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Nov 1, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 594796d into cms-sw:CMSSW_13_2_X Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants