-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cmsDriver arguments in testTauEmbeddingProducers #43116
fix cmsDriver arguments in testTauEmbeddingProducers #43116
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43116/37373
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages:
@civanch, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ae870/35423/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 please merge this bug fix, the test has been broken in IBs for several days now. |
+1 |
PR description:
The integration of #43042 revealed an error in the unit test for
TauAnalysis/MCEmbeddingTools
. A fairly trivial error in this case, but still another good illustration of why more precise parsing is important for ensuring the correctness of our software.PR validation:
Unit test passes.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Unnecessary.