Update the Phase-2 L1 vertex tag in the P2GT producer

[artlbv]

PR description:

The updated collection has a new instance name: L1VerticesEmulation

Corresponds to this PR into the L1 offline repo: cms-l1t-offline#1169

PR validation:

Transparent change, validated in the L1 menu studies for the FastHisto PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

NTR

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43109/37356

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @artlbv (Artur Lobanov) for master.

It involves the following packages:

• L1Trigger/Phase2L1GT (upgrade, l1)

@aloeliger, @cmsbuild, @epalencia, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c627b/35403/summary.html
COMMIT: 770de7c
CMSSW: CMSSW_13_3_X_2023-10-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43109/35403/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cerminar Phase-2 L1T: Fix GT packed format for Correlator e/gamma and tau objects #43075
• @fwyzard Implement std::array-like wrapper #43076
• @kpedro88 argparse migration for cmsDriver and FWCore #43042
• @waredjeb Fix GlobalTag for dumping Fireworks Geometry #43098

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c627b/35403/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c627b/35403/git-merge-result

Comparison Summary

Summary:

• You potentially added 77 lines to the logs
• Reco comparison results: 26 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3351458
• DQMHistoTests: Total failures: 1067
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3350369
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[epalencia]

+l1

[artlbv]

hi, is there anything else missing to get this merged? thanks!

[srimanob]

Hi @artlbv

Could you please clarify few thins:
(1) Is this kind of bug-fix, or both collections exist?
(2) I don't see any change in PR test. Is this because the P2GT is not used in test workflow, right?

[artlbv]

(1) Is this kind of bug-fix, or both collections exist?

The "L1VerticesEmulation" is the new TrackTrigger vertex collection after some major updates on the GTT.
The "old" collection exists in the 13_1 samples, but should not be reproduced when rerunning the L1 afaik. Maybe @BenjaminRS can precise this?

(2) I don't see any change in PR test. Is this because the P2GT is not used in test workflow, right?

Exactly, the P2GT is not in any standard sequence.

[aloeliger]

@cms-sw/upgrade-l2 While the L1 team is considering the creation of prototype phase 2 workflows, is there any objection to signing on this?

[BenjaminRS]

Hi - yes when running the latest code after #42129 was merged then the new collection name would be L1VerticesEmulation

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1