Allow TrackerMuons with only an ME0 segment match

[watson-ij]

PR description:

When only GEM segments from ME0 are matched to a track (e.g. at high eta where CSC doesn't cover), a TrackerMuon is not created because the MuonIdProducer only looks for DT or CSC segments when checking for a good TrackerMuon (requires at least one segment matched to the inner detector track). This PR adds GEM segments to the count of segments in MuonIdProducer, so that inner detector tracks which match to only an ME0 segment will pass the isGoodTrackerMuon and be saved into the reco muon collection.

PR validation:

Ran the phase-2 workflow 24811.0_TenMuExtendedE_0_200+2026D98 and checked before and after the changes that muons at high eta (|eta| > 2.4) which had a me0 segment match were not being saved before the changes, and are now being saved to the reco muon collection after the changes.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43107/37352

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43107/37352/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43107/37352/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43107/37354

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @watson-ij (Ian J. Watson) for master.

It involves the following packages:

• RecoMuon/MuonIdentification (reconstruction)

@mandrenguyen, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@cericeci, @bellan, @JanFSchulte, @rociovilar, @jhgoh, @missirol, @andrea21z, @Fedespring, @abbiendi, @HuguesBrun, @trocino, @CeliaFernandez this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0f421/35401/summary.html
COMMIT: f24a309
CMSSW: CMSSW_13_3_X_2023-10-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43107/35401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 86 lines to the logs
• Reco comparison results: 1331 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3351458
• DQMHistoTests: Total failures: 377
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3351059
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

@watson-ij do we understand why the number of muons being registered in the DQM monitoring seem to be reduced by these changes?
See blue histograms w.r.t. black in wfs: 23234.0, 24834.0 and 25034.999 on
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_3_X_2023-10-24-2300+a0f421/59406/dqm-histo-comparison-summary.html

Thanks

[watson-ij]

@jfernan2 I think it should only add additional high eta muons, but I will check and see if I can figure out what happens in those workflows.

[jfernan2]

enable profiling

Let's check timing in the next iteration of this PR to see the impact of this high eta muon additions

[jfernan2]

BTW: @watson-ij this PR somehow relates to this long standing issue:
#31424
I am not sure if we can take the occasion to move forward in that front. Thanks

[watson-ij]

Thanks @missirol for the detailed explanation. One thing that was missing from what you sent is that the HLT python config also has a GEMDebug parameter for the GEMSegmentAlgorithm which doesn't seemed to be used at all. I added it into the fillDescriptions also to make a test workflow run.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43107/38068

• This PR adds an extra 44KB to repository

[cmsbuild]

Pull request #43107 was updated. @mandrenguyen, @srimanob, @cmsbuild, @mmusich, @jfernan2, @Martin-Grunewald can you please check and sign again.

[watson-ij]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0f421/36322/summary.html
COMMIT: 2ba14ee
CMSSW: CMSSW_14_0_X_2023-12-04-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43107/36322/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 31 lines to the logs
• Reco comparison results: 1046 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3370032
• DQMHistoTests: Total failures: 303
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3369707
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[mmusich]

unassign hlt

• looks OK now

[srimanob]

+Upgrade

See changes in Phase-2 workflows, 23234.0, 24834.0, and 25034.999. This is expected from PR description.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1