-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argparse migration for PhysicsTools and FWLite #43102
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43102/37343
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages:
@Dr15Jones, @simonepigazzini, @smuzaffar, @cmsbuild, @tvami, @makortel, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-585fe4/35392/summary.html Comparison SummarySummary:
|
+1 |
Comparison differences are related to #39803 |
+core |
+analysis |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Followup to #43042. Probably the last one of these I'll have time to do.
PR validation:
Ran each script to ensure it still works. Unit tests pass.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Unlikely to be backported.