-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct url of the GEN fragment in a Pythia8Interface test and of the RelMon main page, after SSO migration #43093
Correct url of the GEN fragment in a Pythia8Interface test and of the RelMon main page, after SSO migration #43093
Conversation
assign pdmv @cms-sw/pdmv-l2 the unit test error showed up first in CMSSW_13_3_X_2023-10-22-2300, while it was not present in the previous days IBs: did you move your staffs sometimes on Sunday? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43093/37331
|
New categories assigned: pdmv @AdrianoDee,@sunilUIET,@miquork you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Pull Request was created by @perrotta (Andrea Perrotta) for master. It involves the following packages:
@GurpreetSinghChahal, @mkirsano, @cmsbuild, @SiewYan, @sunilUIET, @alberto-sanchez, @menglu21, @miquork, @bbilin, @AdrianoDee can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
type bug |
Ah, sorry @iarspider I did not notice it, while I should have checked... |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfe9cc/35368/summary.html Comparison SummarySummary:
|
Hi @perrotta This change, to access McM, get in with recent SSO migration https://cms-talk.web.cern.ch/t/pdmv-mcm-migration-to-the-new-sso/30378 So, we will need to update the pdmv url in scripts. |
Thank you @sunilUIET |
49bd787
to
a7ea6fd
Compare
please test |
+pdmv |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfe9cc/35402/summary.html Comparison SummarySummary:
|
@cms-sw/generators-l2 @cms-sw/dqm-l2 : this is rather trivial, and already approved by pdmv. Could you please have a look? |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Unit test "TestGeneratorInterfacePythia8ConcurrentGeneratorFilter" was failing in the IBs because of a modified address in the pdmv repository of the GEN fragment needed for the test:
From: cms-pdmv.cern.ch
To: cms-pdmv-prod.web.cern.ch
The change in the url of pdmv scripts, to access McM, get in with recent SSO migration
Since I found another such case in Utilities/RelMon/python/definitions.py, I decided to fix also the url listed there in this PR (title and description modified from the original PR)
PR validation:
scram b runtests
works without errorsBackports
The unit test is currently failing in all releases: if we want to fix it, this simple fix should be backported in all them