Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Adding d0 cut to TrackletCalculatorDisplaced.cc #43054

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Jingyan95
Copy link
Contributor

Back porting PR#43014 to 13_1_X

Adding d0 cut to TrackletCalculatorDisplaced.cc
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2023

A new Pull Request was created by @Jingyan95 (Jack Li) for CMSSW_13_1_X.

It involves the following packages:

  • L1Trigger/TrackFindingTracklet (l1)

@cmsbuild, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@erikbutz, @missirol, @skinnari, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

@cmsbuild please test

@srimanob
Copy link
Contributor

@antoniovilela @rappoccio
This is a PR I mentioned during ORP. When it is merge, I would like to request new 13_1.
Since this PR effects only Phase-2 L1T, I don't think we need it in 13_2. Thanks.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff8f92/35267/summary.html
COMMIT: fd64b0a
CMSSW: CMSSW_13_1_X_2023-10-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43054/35267/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196443
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196412
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@epalencia
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@srimanob
Copy link
Contributor

Backport of #43014

@srimanob
Copy link
Contributor

Hi @Jingyan95
Thanks for the backport. Could you please fix the Title of PR, to reflect on the update? You can use the same as #43014, with Backport

@Jingyan95 Jingyan95 changed the title Merge pull request #43014 from Jingyan95/Jack_FixIssue#41357 Backport: Adding d0 cut to TrackletCalculatorDisplaced.cc Oct 20, 2023
@Jingyan95
Copy link
Contributor Author

Hi @Jingyan95 Thanks for the backport. Could you please fix the Title of PR, to reflect on the update? You can use the same as #43014, with Backport

Done

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 03071e6 into cms-sw:CMSSW_13_1_X Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants