Do not forward-declare G4VTouchable

[iarspider]

PR description:

Definition of G4VTouchable was changed in recent Geant4 update (from class to alias), thus making it not forward-declarable.

PR validation:

Tested in cms-sw/cmsdist#8741

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43004/37175

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• SimG4CMS/Tracker (simulation)
• SimTracker/TrackerMaterialAnalysis (simulation)
• Validation/Geometry (geometry, dqm)

@bsunanda, @makortel, @rvenditti, @tjavaid, @mdhildreth, @syuvivida, @cmsbuild, @Dr15Jones, @antoniovagnerini, @civanch, @nothingface0 can you please review it and eventually sign? Thanks.
@VourMa, @ebrondol, @bsunanda, @threus, @GiacomoSguazzoni, @fabiocos, @apsallid, @rovere, @youyingli, @VinInn, @missirol, @vargasa, @mmusich, @slomeo, @mtosi, @JanFSchulte, @rishabhCMS, @rbartek, @dgulhan this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[civanch]

@iarspider , thanks for the PR. Please, remove "draft" - by this PR you cannot add a problem.

[civanch]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd124d/35157/summary.html
COMMIT: e9436e2
CMSSW: CMSSW_13_3_X_2023-10-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43004/35157/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356886
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

problems in tests not connected with this PR.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd124d/35177/summary.html
COMMIT: e9436e2
CMSSW: CMSSW_13_3_X_2023-10-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43004/35177/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356898
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

it is pure technical update, @iarspider , please, remove "draft" from this PR.

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1