Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0.X] remove edmCheckMultithreading from hltIntegrationTests #43000

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 12, 2023

backport of #42993

PR description:

As pointed out in #42988 (comment) this is no longer needed, as the Framework doesn't support Legacy module types as of CMSSW_13_0_0_pre3.
This should alleviate the pressure on CERN HTCondor batch nodes in which HLT IBs tests are run, for a more thorough description see #42988 (comment).

PR validation:

Run an integration test from a recent HLT integration ticket CMSHLT-2957

 hltIntegrationTests /users/ddesouza/HI2023/Add_ZDC_Assym/HLT/V1 -n 800 --mc -d output_hltIntegTestPbPb_upc -x "--globaltag auto:phase1_2023_realistic_hi" -x "--eras Run3 --l1-emulator uGT" -x "--l1 L1Menu_CollisionsHeavyIons2023_v1_1_4_xml" -i file:/eos/cms/store/group/phys_heavyions/anstahll/CERN/Run3/2023/MC/STARLIGHT/CohJPsi_STARLIGHT_5p36TeV_2023Run3_RAW_20230812/CohJPsi_STARLIGHT_5p36TeV_2023Run3/CohJPsi_STARLIGHT_5p36TeV_2023Run3_RAW_20230812/230812_063634/0000/step2_STARlight_Digi_10.root -x "--no-output --open --paths HLT_HIUPC*nAsymXOR*" >& test.txt &

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #42993 to 13.0.X

- this is no longer needed, as the Framework doesn't support Legacy module types as of CMSSW_13_0_0_pre3
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @mmusich, @Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 12, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87b287/35151/summary.html
COMMIT: cc45789
CMSSW: CMSSW_13_0_X_2023-10-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43000/35151/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 241 lines from the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283620
  • DQMHistoTests: Total failures: 986
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3282612
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 12, 2023

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@Martin-Grunewald
Copy link
Contributor

urgent

  • to fix problems in IB tests

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3ae971b into cms-sw:CMSSW_13_0_X Oct 16, 2023
@mmusich mmusich deleted the remove_edmCheckMultithreading_13_0_X branch October 16, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants