-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hltPrintMenuVersions
and utilities for HLT-menu spreadsheets
#42967
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42967/37133
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@cmsbuild, @Martin-Grunewald, @mmusich, @missirol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f92cf4/35091/summary.html Comparison SummarySummary:
|
+hlt
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hello, The newly introduced test
If I am not mistaken, oracle version for Many thanks, |
is it acceptable to skip the unit test under this architecture? These scripts are used only from STORM during menu integration and we certainly won't run them in "exotic" architectures. Also tagging @cms-sw/core-l2 for an opinion. |
Thanks, @aandvalenzuela . I had a look, but I didn't find the solution. I opened #42975 to follow up. |
If HLT considers the functionality being tested as not necessary for ARM (or non-x86) CPUs, feel free to disable the test. |
PR description:
This PR adds a few utilities related to the maintenance of the HLT menus.
hltPrintMenuVersions
is a modified version of a script shared by @silviodonato to print to stdout metadata ("save comment" and "release template") of each version of a given HLT menu in ConfDB. I have added some command-line options to it usingargparse
(see--help
for more info). Some examples below.hltPrintMenuVersions /dev/CMSSW_13_2_0/Fake2 -c 'cms_hlt_v3_r/convertMe!@cmsr' hltPrintMenuVersions /dev/CMSSW_13_2_0/Fake2 --db run3 hltPrintMenuVersions /dev/CMSSW_10_0_0/Fake2 --db run2 hltPrintMenuVersions /cdaq/special/PilotBeamTest2021/Circulating --db adg
Upon the release of a new HLT menu for data-taking (or MC production), TSG produces a spreadsheet which contains information on the content of the menu. The tools used to create this spreadsheet are added in this PR to
HLTrigger/Configuration/scripts/utils
(see the readme file inscripts/utils
for further details).Unit tests for
hltPrintMenuVersions
andhltMenuContentToCSVs
are included. (These new tests rely on connecting to ConfDB, so I fear they might occasionally fail due to connection glitches, based on what I remember from #37598 (comment).)PR validation:
Manual tests (and the new unit tests pass).
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
A backport is not necessary, but this PR could be backported down to the release cycle used for HLT-menu development (i.e.
13_2_X
) if it is useful.