Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hltPrintMenuVersions and utilities for HLT-menu spreadsheets #42967

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Oct 7, 2023

PR description:

This PR adds a few utilities related to the maintenance of the HLT menus.

  • hltPrintMenuVersions is a modified version of a script shared by @silviodonato to print to stdout metadata ("save comment" and "release template") of each version of a given HLT menu in ConfDB. I have added some command-line options to it using argparse (see --help for more info). Some examples below.

    hltPrintMenuVersions /dev/CMSSW_13_2_0/Fake2 -c 'cms_hlt_v3_r/convertMe!@cmsr'
    hltPrintMenuVersions /dev/CMSSW_13_2_0/Fake2 --db run3                        
    hltPrintMenuVersions /dev/CMSSW_10_0_0/Fake2 --db run2
    hltPrintMenuVersions /cdaq/special/PilotBeamTest2021/Circulating --db adg                        
  • Upon the release of a new HLT menu for data-taking (or MC production), TSG produces a spreadsheet which contains information on the content of the menu. The tools used to create this spreadsheet are added in this PR to HLTrigger/Configuration/scripts/utils (see the readme file in scripts/utils for further details).

Unit tests for hltPrintMenuVersions and hltMenuContentToCSVs are included. (These new tests rely on connecting to ConfDB, so I fear they might occasionally fail due to connection glitches, based on what I remember from #37598 (comment).)

PR validation:

Manual tests (and the new unit tests pass).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

A backport is not necessary, but this PR could be backported down to the release cycle used for HLT-menu development (i.e. 13_2_X) if it is useful.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42967/37133

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @Martin-Grunewald, @mmusich, @missirol can you please review it and eventually sign? Thanks.
@silviodonato, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Oct 8, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f92cf4/35091/summary.html
COMMIT: d4d0faa
CMSSW: CMSSW_13_3_X_2023-10-08-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42967/35091/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356889
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Oct 9, 2023

+hlt

  • this PR adds few utils needed from STORM for day-to-day work. They don't affect any production workflow in any way.
  • thanks @missirol !

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b87cab8 into cms-sw:master Oct 9, 2023
@aandvalenzuela
Copy link
Contributor

Hello,

The newly introduced test test_hltPrintMenuVersions is failing in aarch64 (CMSSW_13_3_X_2023-10-09-2300) due to:

Failure 'hltPrintMenuVersions /dev/CMSSW_13_0_0/Fake2': status 1
=== Log File ==========
HLT Configuration: /dev/CMSSW_13_0_0/Fake2 (database = "run3")

Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/aarch64/nweek-02806/el8_aarch64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-10-09-2300/bin/el8_aarch64_gcc11/hltPrintMenuVersions", line 130, in <module>
    hltMenuVersions = getHLTMenuVersions(
  File "/cvmfs/cms-ib.cern.ch/sw/aarch64/nweek-02806/el8_aarch64_gcc11/cms/cmssw/CMSSW_13_3_X_2023-10-09-2300/bin/el8_aarch64_gcc11/hltPrintMenuVersions", line 10, in getHLTMenuVersions
    conn = cx_Oracle.connect(connect_string)
cx_Oracle.DatabaseError: DPI-1072: the Oracle Client library version is unsupported
=== End of Log File ===

If I am not mistaken, oracle version for aarch64 is different from amd64 and it is defined at https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_13_3_X/master/oracle.spec#L6.
Could you please have a look at the issue?

Many thanks,
Andrea.

@missirol missirol deleted the devel_hltUtils branch October 10, 2023 14:17
@mmusich
Copy link
Contributor

mmusich commented Oct 10, 2023

Could you please have a look at the issue?

is it acceptable to skip the unit test under this architecture? These scripts are used only from STORM during menu integration and we certainly won't run them in "exotic" architectures. Also tagging @cms-sw/core-l2 for an opinion.

@missirol
Copy link
Contributor Author

Could you please have a look at the issue?

Thanks, @aandvalenzuela . I had a look, but I didn't find the solution. I opened #42975 to follow up.

@makortel
Copy link
Contributor

Could you please have a look at the issue?

is it acceptable to skip the unit test under this architecture? These scripts are used only from STORM during menu integration and we certainly won't run them in "exotic" architectures. Also tagging @cms-sw/core-l2 for an opinion.

If HLT considers the functionality being tested as not necessary for ARM (or non-x86) CPUs, feel free to disable the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants