Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing re-binnning from SiStripBadAPVandHotStripAlgorithm #42956

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

jlidrych
Copy link
Contributor

@jlidrych jlidrych commented Oct 5, 2023

PR description:

This PR is related to this issue.
The proposed changes should be harmless - only unnecessary re-binning is removed.

PR validation:

It compiles. I tried runTheMatrix.py -l limited --useInput all --ibeos and it passed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42956/37105

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

A new Pull Request was created by @jlidrych for master.

It involves the following packages:

  • CalibTracker/SiStripQuality (alca)

@consuegs, @saumyaphor4252, @perrotta, @cmsbuild can you please review it and eventually sign? Thanks.
@gbenelli, @mmusich, @tocheng, @echabert, @robervalwalsh this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Oct 5, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b338f/35063/summary.html
COMMIT: 0d0c42d
CMSSW: CMSSW_13_3_X_2023-10-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42956/35063/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356892
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Oct 6, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c07e13c into cms-sw:master Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants