Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily remove HLT_DoubleMediumDeepTauPFTauHPS35_eta2p1 from phase-2 HLT menu #42955

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 5, 2023

PR description:

See #42862, temporary measure to avoid relval failures.

PR validation:

None

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42955/37103

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@SohamBhattacharya, @Martin-Grunewald, @rovere, @silviodonato, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 6, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c07edd/35076/summary.html
COMMIT: ae7af3f
CMSSW: CMSSW_13_3_X_2023-10-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42955/35076/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 27 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356898
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 9, 2023

@rovere @SohamBhattacharya please confirm you are OK with the (temporary) removal of the failing tau HLT path in the phase-2 menu (given the conclusions at #42862 (comment)).

@mmusich
Copy link
Contributor Author

mmusich commented Oct 9, 2023

+hlt

  • taking "thumbs up" as a confirmation ;)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6e034de into cms-sw:master Oct 9, 2023
@mmusich mmusich deleted the remove_HLT_DoubleMediumDeepTauPFTauHPS35_eta2p1 branch October 23, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants