Phase2-trk10 Possible overlap removal in the T33 version of tracker geometry

[bsunanda]

PR description:

Possible overlap removal in the T33 version of tracker geometry. Two possible ways of removing the overlap - (1) by reducing the length of ModuleDeadAreaFront|Back or by repositioning ModuleDeadAreaRight|Left. The final choice will be taken after consulting with Tracker DPG

PR validation:

Tested using the Geant4 Overlap testing tool

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42951/37097

• This PR adds an extra 56KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/TrackerCommonData (geometry)

@cmsbuild, @civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@JanFSchulte, @VourMa, @fabiocos, @VinInn, @ghugo83, @vargasa, @mmusich, @mtosi, @venturia this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0e049/35052/summary.html
COMMIT: 924e18e
CMSSW: CMSSW_13_3_X_2023-10-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42951/35052/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356895
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

@bsunanda , I would propose instead of given 2 choices propose MR with V1 variant, where "V1" is not included in the file name. This would be possible to merge. With time phase2 tracker experts may propose better solution on top.

[bsunanda]

@civanch Once this PR is merged I can make V1 as the default till Tracker DPG thinks otherwise

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[civanch]

OK, agreed.

[antoniovilela]

+1