Fix logic error in FinalPath checks

[fwyzard]

PR description:

If an EDProducer or EDFilter is inserted in a FinalPath, the job fails with a cryptic error:

----- Begin Fatal Exception 03-Oct-2023 15:42:41 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named dump.py
Exception Message:
 unknown python problem occurred.
AttributeError: 'str' object has no attribute 'label_'

At:
  /data/user/fwyzard/CMSSW_13_3_X_2023-10-02-2300/src/FWCore/ParameterSet/python/Config.py(1292): <listcomp>
  /data/user/fwyzard/CMSSW_13_3_X_2023-10-02-2300/src/FWCore/ParameterSet/python/Config.py(1292): _insertPaths
  /data/user/fwyzard/CMSSW_13_3_X_2023-10-02-2300/src/FWCore/ParameterSet/python/Config.py(1490): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

With these changes, the error is more meaningful:

----- Begin Fatal Exception 03-Oct-2023 15:46:00 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named dump.py
Exception Message:
 unknown python problem occurred.
RuntimeError: FinalPath HLTriggerFinalPath has non OutputModules HLTBool,TriggerSummaryProducerRAW

At:
  /data/user/fwyzard/CMSSW_13_3_X_2023-10-02-2300/src/FWCore/ParameterSet/python/Config.py(1290): _insertPaths
  /data/user/fwyzard/CMSSW_13_3_X_2023-10-02-2300/src/FWCore/ParameterSet/python/Config.py(1487): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Implement the python checks to notify that also EDAnalyzers are not supported on FinalPaths.

The unit tests are extended to catch the error.

PR validation:

The extended unit tests pass.

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42936/37082

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HLTrigger/Configuration/python/HLT_75e33/services/ThroughputService_cfi.py modified in PR(s): Add FastTimer and Throughput Services to HLT Phase2 timing menu. #42934
  • File HLTrigger/Configuration/python/HLT_75e33_timing_cff.py modified in PR(s): Add FastTimer and Throughput Services to HLT Phase2 timing menu. #42934

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@missirol, @Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@silviodonato, @rovere, @missirol, @SohamBhattacharya, @Martin-Grunewald this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

@cmsbuild, please abort

[fwyzard]

wrong cherry-pick...

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42936/37084

• This PR adds an extra 48KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/ParameterSet/python/Config.py modified in PR(s): [DO-NOT merge] Revert "Enforce Modifier consistency between Process instances" #37996

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42936/37889

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/ParameterSet/python/Config.py modified in PR(s): [DO-NOT merge] Revert "Enforce Modifier consistency between Process instances" #37996, faster edmConfigDump with --prune, also prunes unreferenced PSets #43276

[cmsbuild]

Pull request #42936 was updated. @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9479fe/36061/summary.html
COMMIT: 0f1e9ae
CMSSW: CMSSW_14_0_X_2023-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42936/36061/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test condTestRegression had ERRORS

Comparison Summary

Summary:

• You potentially added 27 lines to the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3367918
• DQMHistoTests: Total failures: 23
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3367873
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[fwyzard]

The error seems unrelated.

[makortel]

Comparisons show #43415

[makortel]

+core

Thanks @fwyzard!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

[antoniovilela]

merge