Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] Add FastTimer and Throughput Services to HLT P2 timing menu. #42935

Merged

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Oct 3, 2023

PR description:

Backport of #42934

PR validation:

Tested locally on top of 13_1_1.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_13_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@mmusich, @missirol, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @missirol, @SohamBhattacharya, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented Oct 3, 2023

please test

@mmusich
Copy link
Contributor

mmusich commented Oct 3, 2023

@rovere please edit the title such that it's clear what's the target branch

@mmusich
Copy link
Contributor

mmusich commented Oct 3, 2023

backport of #42934

@rovere rovere changed the title Add FastTimer and Throughput Services to HLT P2 timing menu. [13_1_X] Add FastTimer and Throughput Services to HLT P2 timing menu. Oct 3, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f5599/35026/summary.html
COMMIT: 64e8624
CMSSW: CMSSW_13_1_X_2023-10-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42935/35026/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3187455
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187427
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Oct 4, 2023

please test

  • let's try again

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f5599/35031/summary.html
COMMIT: 64e8624
CMSSW: CMSSW_13_1_X_2023-10-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42935/35031/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3187455
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187433
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Oct 4, 2023

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label Oct 6, 2023
@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 55600b8 into cms-sw:CMSSW_13_1_X Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants