Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runTheMatrix interactive shell #42923

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Oct 2, 2023

PR description:

Add the possibility to submit runTheMatrix workflows directly from within the interactive session.

PR validation:

Tested inside an interactive session.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42923/37067

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2023

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@cmsbuild, @AdrianoDee, @sunilUIET, @miquork, @srimanob can you please review it and eventually sign? Thanks.
@slomeo, @makortel, @fabiocos, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented Oct 2, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734b5b/35002/summary.html
COMMIT: ce06ef9
CMSSW: CMSSW_13_3_X_2023-10-01-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42923/35002/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358320
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358298
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@rovere
Copy link
Contributor Author

rovere commented Oct 2, 2023

It is not clear to me if the failures could be somehow related to this PR...

@AdrianoDee
Copy link
Contributor

Seems not to me. If I understood correctly it's a timeout error to get the data. Let's retry.

@AdrianoDee
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-734b5b/35013/summary.html
COMMIT: ce06ef9
CMSSW: CMSSW_13_3_X_2023-10-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42923/35013/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358320
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358295
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Oct 6, 2023

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants