Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T0 scenario for repacked pp #42891

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

mandrenguyen
Copy link
Contributor

New T0 scenario for pp reco, but with the RAW data format that is repacked at the HLT.
https://cms-talk.web.cern.ch/t/possible-issue-with-t0-config-for-hi-prompt-reco

A backport to 13_2_X will be made.

Tested with the help of German.

@mandrenguyen
Copy link
Contributor Author

urgent
For ongoing data-taking

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42891/37027

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@antoniovilela, @fabiocos, @davidlange6, @rappoccio can you please review it and eventually sign? Thanks.
@fabiocos, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

I know this is urgent, but shouldn't it at be least added in the tests:

declare -a arr=("ppEra_Run3")

?

@mandrenguyen
Copy link
Contributor Author

I know this is urgent, but shouldn't it at least added in the tests:

declare -a arr=("ppEra_Run3")

?
Ah, thanks, so just:
declare -a arr=("ppEra_Run3" "ppEra_Run3_repacked")
?

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

declare -a arr=("ppEra_Run3" "ppEra_Run3_repacked")

I think so, but haven't tested it :)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42891/37029

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42891 was updated. @davidlange6, @rappoccio, @cmsbuild, @fabiocos, @antoniovilela can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42891/37031

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42891 was updated. @antoniovilela, @fabiocos, @rappoccio, @davidlange6, @cmsbuild can you please check and sign again.

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce39a9/34946/summary.html
COMMIT: 6b69173
CMSSW: CMSSW_13_3_X_2023-09-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42891/34946/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358320
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358292
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 5737353 into cms-sw:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants