Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the scouting event content to MINIAODSIM #42863

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

elfontan
Copy link
Contributor

@elfontan elfontan commented Sep 26, 2023

PR description:

In the context of the discussion about the plans for scouting in Run 3, the inclusion of the scounting event content within MINIAODSIM data tier was discussed per request of TSG and @dsperka in order to simplify scouting studies and analyses based on scouting data. The request was signed-off by PPD, PC, and O&C.
The plan is to include the change in the master branch to have those collections available from 133X so that it will be part of the campaigns for the TSG 2024 preparation and next year PPD operation.

PR validation:

The effect of the change on the event size was tested with a 2023 MinBias, a 2023 ttbar sample, and a 2022 ttHbb sample using a recent 13_3_X release (@kelmorab).
The summary finding is that the average event size (measured with the disksize.pl script from SWGuidePATEventSize) depends on the process:

  • MinBias: +5.6 kb from scouting event content -> 12.1%
  • ttbar: +11.7 kb from scouting event content -> 8.9%
  • ttHbb: +8.7 kb from scouting event content -> 10.4%

The PR has been prepared starting from CMSSW_13_3_X_2023-09-25-1100:

cmsrel CMSSW_13_3_X_2023-09-25-1100
cd CMSSW_13_3_X_2023-09-25-1100/src
cmsenv
git cms-init
git cms-addpkg Configuration/EventContent
scram b && scram b code-checks && scram b code-format && scram b

[cc: @missirol @goys @simonepigazzini @jordan-martins]

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42863/36998

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @elfontan (Elisa Fontanesi) for master.

It involves the following packages:

  • Configuration/EventContent (operations)

@cmsbuild, @antoniovilela, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@simonepigazzini
Copy link
Contributor

please test

@simonepigazzini
Copy link
Contributor

Thank you for the PR. Can you remind us if a discussion happened concerning the option of having the scouting collections added only to specific productions?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c54c9/34899/summary.html
COMMIT: 59c14bf
CMSSW: CMSSW_13_3_X_2023-09-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42863/34899/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358016
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@simonepigazzini
Copy link
Contributor

From the XPOG side this PR is ready to go in. It has been clarified in offline discussions that the changes to the MINIAODSIM format are accepted by all interested parties.

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 8efd906 into cms-sw:master Sep 27, 2023
cmsbuild added a commit that referenced this pull request Nov 20, 2023
Add HLT-Scouting collections to `MINIAOD` event content (follow-up of #42863)
cmsbuild added a commit that referenced this pull request Nov 21, 2023
Add HLT-Scouting collections to `MINIAOD` event content (follow-up of #42863) [`13_3_X`]
zhenbinwu pushed a commit to zhenbinwu/cmssw that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants