-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ECAL reconstructions to use different time calibration records - 132x #42861
Enable ECAL reconstructions to use different time calibration records - 132x #42861
Conversation
…ions on GPU and other algos.
A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_2_X. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type ecal |
backport of #42860 |
enable gpu |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ba17c3/34896/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
assign hlt |
New categories assigned: hlt @mmusich,@missirol,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks |
unassign hlt
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Adding two ESInputTag parameters to be able to select the record that the timing calibrations and timing offsets are taken from by the GPU multifit algorithm and other ECAL time reconstructions.
This will be needed to support two records of those conditions within a GT.
Having two records in a GT will be required in some cases (e.g. MC GTs) because two different timing algorithms, using two different sets of conditions, run at the HLT and in offline reconstruction.
This PR just adds the capability to specify the record label but no changes to configuration are made and no changes in existing workflows are expected.
This is a follow up PR to #42845 , which added this capability already to the CPU multifit algorithm.
PR validation:
Passes limited matrix tests.
Backport of #42860
This backport is mostly needed to enable the same condition selection feature that the CPU multifit algorithm has received with PR #42845 also for the GPU amplitude reconstruction.