-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2D comparison histograms to SiStripMonitorApproximateCluster
#42852
Add 2D comparison histograms to SiStripMonitorApproximateCluster
#42852
Conversation
Compare approximate and regular clusters for: - cluster size - cluster charge - cluster barycenter - first strip in cluster - last strip in cluster
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42852/36987
|
test parameters:
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ea5cae/34882/summary.html Comparison SummarySummary:
|
@cms-sw/dqm-l2 can you please sign also this PR (master version of #42853)? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Somewhat inspired by this presentation, added 2D (underlying
ROOT
typeTH2I
) histograms to compare approximate and regular clusters for:PR validation:
Tested with the recipe at this gdoc:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, to be backported to 13.2.X for 2023 HI data-taking