Add a Phase2 HLT tracking DQM monitoring (13.1.X) #42827

mmusich · 2023-09-19T20:57:09Z

backport of #42783

PR description:

Minimal set of changes needed to the Tracking @ HLT DQM monitoring sequence for the Phase-2 setup.
This relies on the current naming of the tracking collections for the phase-2 HLT:

generalTracks (somewhat copied from offline)
hltPhase2PixelTracks (pixel tracks)
hltPhase2PixelVertices (pixel vertices)

The latter two were introduced in #42512 but the name change was not percolated to the FEVTDEBUGHLTEventContent, so it becomes necessary to include them in the list of collections to be persisted.
Changes for making the Phase-2 HLT Validation are more extensive and will be addressed with another PR at a later time.

PR validation:

Run successfully runTheMatrix.py -l 20834.0 -t 4 -j 8 (and checked that the HLT tracking plots are full).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #42783

…entContent in the phase-2 case

…ing in the phase-2 case

…one in the case of the phase-2 HLT monitoring

…orCluster

cmsbuild · 2023-09-19T20:57:34Z

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X.

It involves the following packages:

Configuration/EventContent (operations)
DQM/SiTrackerPhase2 (dqm)
DQMOffline/Configuration (dqm)
DQMOffline/Trigger (dqm)

@cmsbuild, @rappoccio, @nothingface0, @emanueleusai, @davidlange6, @pmandrik, @syuvivida, @antoniovilela, @tjavaid, @micsucmed, @fabiocos, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @trocino, @sroychow, @Fedespring, @Martin-Grunewald, @missirol, @HuguesBrun, @jhgoh, @threus, @mtosi, @fabiocos, @cericeci, @rociovilar this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Backported from Add a Phase2 HLT tracking DQM monitoring #42783

mmusich · 2023-09-19T20:58:04Z

please test

cmsbuild · 2023-09-19T23:25:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c666ab/34831/summary.html
COMMIT: ecc4d62
CMSSW: CMSSW_13_1_X_2023-09-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42827/34831/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 74 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3187455
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3187422
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 413379.2159999999 KiB( 47 files compared)
DQMHistoSizes: changed ( 23234.0,... ): 28071.181 KiB HLT/TrackerPhase2ITCluster
DQMHistoSizes: changed ( 23234.0,... ): 28052.799 KiB HLT/TrackerPhase2OTCluster
DQMHistoSizes: changed ( 23234.0,... ): 12219.999 KiB HLT/Tracking
DQMHistoSizes: changed ( 23234.0,... ): 551.987 KiB HLT/Vertexing
DQMHistoSizes: changed ( 23234.0,... ): 0.570 KiB HLT/EventInfo
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

emanueleusai · 2023-09-20T20:36:07Z

+1

rappoccio · 2023-09-27T20:15:07Z

@mmusich is this supposed to be promoted from a draft now?

mmusich · 2023-09-27T21:21:47Z

@rappoccio

is this supposed to be promoted from a draft now?

unfortunately not yet. The plots were added but they are all empty: https://tinyurl.com/27qslwcs.
I haven't had yet time to investigate why. I'll come back to this as soon as I can.

mmusich · 2023-10-04T09:46:54Z

The plots were added but they are all empty: https://tinyurl.com/27qslwcs.

OK, I had some time to look at this and reason why wf 23234.0 plots are empty is rather mundane.
Wf 23234.0 employs geometry D94:

cmssw/Configuration/PyReleaseValidation/python/relval_2026.py

Line 27 in 15594bf

numWFIB.extend([23234.0]) #2026D94

and for that geometry we run the fake menu:

cmssw/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

Lines 2583 to 2589 in 15594bf

    
           '2026D94' : { 
        
               'Geom' : 'Extended2026D94', 
        
               'HLTmenu': '@fake2', 
        
               'GT' : 'auto:phase2_realistic_T21', 
        
               'Era' : 'Phase2C20I13M9', 
        
               'ScenToRun' : ['GenSimHLBeamSpot','DigiTrigger','RecoGlobal', 'HARVESTGlobal', 'ALCAPhase2'], 
        
           },

so, of course there aren't HLT products available for DQM.
I privately re-run runTheMatrix.py -l 20834.0 -t 4 -j 8 which uses D88 instead:

cmssw/Configuration/PyReleaseValidation/python/relval_2026.py

Line 18 in 15594bf

numWFIB.extend([20834.0]) #2026D88

(which runs the real phase-2 menu)

cmssw/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

Lines 2555 to 2561 in 15594bf

    
           '2026D88' : { 
        
               'Geom' : 'Extended2026D88', 
        
               'HLTmenu': '@relval2026', 
        
               'GT' : 'auto:phase2_realistic_T21', 
        
               'Era' : 'Phase2C17I13M9', 
        
               'ScenToRun' : ['GenSimHLBeamSpot','DigiTrigger','RecoGlobal', 'HARVESTGlobal', 'ALCAPhase2'], 
        
           },

and I see filled plots. So I think we can go ahead with this PR.

mmusich · 2023-10-04T09:50:42Z

test parameters:

workflows = 20834.0, 23634.0
relvals_opt= -w upgrade

mmusich · 2023-10-04T09:51:04Z

@cmsbuild, please test

tests are bit stale by now.

cmsbuild · 2023-10-04T12:39:26Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c666ab/35037/summary.html
COMMIT: ecc4d62
CMSSW: CMSSW_13_1_X_2023-10-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42827/35037/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 99 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3281900
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3281873
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 482275.75199999986 KiB( 48 files compared)
DQMHistoSizes: changed ( 23234.0,... ): 28071.181 KiB HLT/TrackerPhase2ITCluster
DQMHistoSizes: changed ( 23234.0,... ): 28052.799 KiB HLT/TrackerPhase2OTCluster
DQMHistoSizes: changed ( 23234.0,... ): 12219.999 KiB HLT/Tracking
DQMHistoSizes: changed ( 23234.0,... ): 551.987 KiB HLT/Vertexing
DQMHistoSizes: changed ( 23234.0,... ): 0.570 KiB HLT/EventInfo
Checked 212 log files, 163 edm output root files, 49 DQM output files
TriggerResults: no differences found

rovere · 2023-10-09T13:20:56Z

@mmusich do you think it makes sense to integrate this in 13_1? The Review is over, there's P2UG coming, but I'm not sure.

mmusich · 2023-10-09T13:23:05Z

@rovere

do you think it makes sense to integrate this in 13_1?

well, why not. If there's more PRs that you want to be integrated in the queue this one might enter as well.

rappoccio · 2023-10-10T14:36:35Z

+1

cmsbuild · 2023-10-10T14:37:03Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.

slava77 · 2023-10-22T17:01:19Z

type tracking

mmusich added 5 commits September 19, 2023 20:31

add hltPhase2PixelTracks and hltPhase2PixelVertices to FEVTDEBUGHLTEv…

e7b7853

…entContent in the phase-2 case

minimal set of modifications in order to run the HLT tracking monitor…

ba141c5

…ing in the phase-2 case

allow HLTMon sequence to run in phase-2

6d3cca1

substitute the Phase-1 pixel HLT offline monitoring with the Phase-2 …

b51b519

…one in the case of the phase-2 HLT monitoring

add protection against missing input collections in Phase2IT{OT}Monit…

ecc4d62

…orCluster

cmsbuild added this to the CMSSW_13_1_X milestone Sep 19, 2023

cmsbuild added dqm-pending operations-pending pending-signatures tests-pending orp-pending backport-ok trk labels Sep 19, 2023

cmsbuild added tests-started and removed tests-pending labels Sep 19, 2023

cmsbuild added tests-approved and removed tests-started labels Sep 19, 2023

cmsbuild added dqm-approved and removed dqm-pending labels Sep 20, 2023

mmusich marked this pull request as ready for review October 4, 2023 09:47

cmsbuild removed the tests-approved label Oct 4, 2023

cmsbuild added the tests-started label Oct 4, 2023

mmusich changed the title ~~[WIP] Add a Phase2 HLT tracking DQM monitoring (13.1.X)~~ Add a Phase2 HLT tracking DQM monitoring (13.1.X) Oct 4, 2023

cmsbuild added tests-approved and removed tests-started labels Oct 4, 2023

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Oct 10, 2023

cmsbuild merged commit d55a81b into cms-sw:CMSSW_13_1_X Oct 10, 2023

cmsbuild added the tracking label Oct 22, 2023

mmusich deleted the phase2_hlt_tracking_monitoring_13_1_X branch October 23, 2023 06:19

mmusich mentioned this pull request Oct 27, 2023

[13.1.X] Selected backports of Phase-2 HLT Validation (w.r.t SIM) #43131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a Phase2 HLT tracking DQM monitoring (13.1.X) #42827

Add a Phase2 HLT tracking DQM monitoring (13.1.X) #42827

mmusich commented Sep 19, 2023 •

edited

Loading

cmsbuild commented Sep 19, 2023 •

edited

Loading

mmusich commented Sep 19, 2023

cmsbuild commented Sep 19, 2023

emanueleusai commented Sep 20, 2023

rappoccio commented Sep 27, 2023

mmusich commented Sep 27, 2023

mmusich commented Oct 4, 2023

mmusich commented Oct 4, 2023 •

edited

Loading

mmusich commented Oct 4, 2023

cmsbuild commented Oct 4, 2023

rovere commented Oct 9, 2023

mmusich commented Oct 9, 2023 •

edited

Loading

rappoccio commented Oct 10, 2023

cmsbuild commented Oct 10, 2023

slava77 commented Oct 22, 2023

Add a Phase2 HLT tracking DQM monitoring (13.1.X) #42827

Add a Phase2 HLT tracking DQM monitoring (13.1.X) #42827

Conversation

mmusich commented Sep 19, 2023 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Sep 19, 2023 • edited Loading

mmusich commented Sep 19, 2023

cmsbuild commented Sep 19, 2023

Comparison Summary

emanueleusai commented Sep 20, 2023

rappoccio commented Sep 27, 2023

mmusich commented Sep 27, 2023

mmusich commented Oct 4, 2023

mmusich commented Oct 4, 2023 • edited Loading

mmusich commented Oct 4, 2023

cmsbuild commented Oct 4, 2023

Comparison Summary

rovere commented Oct 9, 2023

mmusich commented Oct 9, 2023 • edited Loading

rappoccio commented Oct 10, 2023

cmsbuild commented Oct 10, 2023

slava77 commented Oct 22, 2023

mmusich commented Sep 19, 2023 •

edited

Loading

cmsbuild commented Sep 19, 2023 •

edited

Loading

mmusich commented Oct 4, 2023 •

edited

Loading

mmusich commented Oct 9, 2023 •

edited

Loading