Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Laser 4 plots in ECAL DQM [13_2_X] #42806

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Sep 18, 2023

PR description:

This PR is to enable the new commissioned green laser plots, named Laser 4 in the ECAL DQM.

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to 13_2_X which is in production at the moment.
The master PR is #42805

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2023

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_13_2_X.

It involves the following packages:

  • DQM/EcalCommon (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @thomreis, @wang0jin this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@emanueleusai
Copy link
Member

type ecal

@emanueleusai
Copy link
Member

backport of #42805

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7713a5/34812/summary.html
COMMIT: b32f1dc
CMSSW: CMSSW_13_2_X_2023-09-18-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42806/34812/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198243
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198212
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • test p5 ok

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ae31b8b into cms-sw:CMSSW_13_2_X Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants