Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phase-2] [backport] Fix usage of L1 egamma seeds in Phase-2 HLT #42792

Conversation

SohamBhattacharya
Copy link
Contributor

@SohamBhattacharya SohamBhattacharya commented Sep 14, 2023

PR description:

Backport of #42791
(Needed for HLT-upgrade annual review)

Tagging Phase-2 Egamma HLT contacts/validators: @ravindkv @skeshri

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2023

A new Pull Request was created by @SohamBhattacharya for CMSSW_13_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • HLTrigger/HLTfilters (hlt)
  • RecoHGCal/TICL (upgrade, reconstruction)

@Martin-Grunewald, @missirol, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mmusich, @mandrenguyen can you please review it and eventually sign? Thanks.
@youyingli, @missirol, @silviodonato, @felicepantaleo, @forthommel, @rovere, @Martin-Grunewald, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @ebrondol, @sameasy this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Sep 14, 2023

backport of #42791

@mmusich
Copy link
Contributor

mmusich commented Sep 14, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

Pull request #42792 was updated. @Martin-Grunewald, @missirol, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @mmusich, @mandrenguyen can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 15, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4052dd/34785/summary.html
COMMIT: 3fdef2c
CMSSW: CMSSW_13_1_X_2023-09-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42792/34785/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3187380
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187354
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 4 / 46 workflows

@jfernan2
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

@mmusich
Copy link
Contributor

mmusich commented Sep 15, 2023

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 45c11cf into cms-sw:CMSSW_13_1_X Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants