Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[130X]: Add run3_miniAOD_12X modifier #42782

Merged

Conversation

simonepigazzini
Copy link
Contributor

PR description:

backport of #42740.

Modifier needed for reMINI campaign of 2022 (data/MC) and 2023 (data).

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Sep 13, 2023
@simonepigazzini
Copy link
Contributor Author

enable nano

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @simonepigazzini for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • PhysicsTools/PatAlgos (xpog, reconstruction)

@rappoccio, @vlimant, @bbilin, @srimanob, @cmsbuild, @AdrianoDee, @miquork, @jfernan2, @simonepigazzini, @antoniovilela, @sunilUIET, @mandrenguyen, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @Ming-Yan, @makortel, @felicepantaleo, @hatakeyamak, @emilbols, @Martin-Grunewald, @mbluj, @ahinzmann, @demuller, @seemasharmafnal, @VourMa, @mmarionncern, @missirol, @Senphy, @JanFSchulte, @dgulhan, @jdolen, @azotz, @slomeo, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mmusich, @mtosi, @fabiocos, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso, @sameasy, @andrzejnovak this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@simonepigazzini
Copy link
Contributor Author

please test

@simonepigazzini
Copy link
Contributor Author

@rappoccio @antoniovilela backport to 131X and 132X will come in the next days.

@simonepigazzini
Copy link
Contributor Author

image
image

Same checks as for the PR to the master, same results. All as expected

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cda2e3/34740/summary.html
COMMIT: 9fea250
CMSSW: CMSSW_13_0_X_2023-09-13-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42782/34740/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 73 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283545
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283520
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12436
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12436
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.460 2.460 0.000 ( +0.0% ) 5.44 5.44 -0.0% 2.093 2.085
2500.311 2.595 2.595 0.000 ( +0.0% ) 4.84 4.85 -0.1% 2.522 2.522
2500.312 2.511 2.511 0.000 ( +0.0% ) 5.04 5.07 -0.6% 2.507 2.509
2500.33 1.253 1.253 0.000 ( +0.0% ) 10.35 10.32 +0.3% 2.210 2.210
2500.331 1.620 1.620 0.000 ( +0.0% ) 5.46 5.48 -0.4% 2.398 2.398
2500.332 1.502 1.502 0.000 ( +0.0% ) 7.95 7.95 -0.0% 2.312 2.301
2500.401 2.117 2.117 0.000 ( +0.0% ) 5.49 5.50 -0.1% 1.950 1.949
2500.501 1.723 1.723 0.000 ( +0.0% ) 9.34 9.26 +0.9% 1.826 1.825
2500.511 1.110 1.110 0.000 ( +0.0% ) 4.54 4.52 +0.3% 2.155 2.148
2500.5111 1.464 1.464 0.000 ( +0.0% ) 4.04 4.08 -0.9% 2.226 2.230
2500.601 1.983 1.983 0.000 ( +0.0% ) 13.26 13.21 +0.3% 1.712 1.709

@jfernan2
Copy link
Contributor

+1

@simonepigazzini
Copy link
Contributor Author

+xpog

@antoniovilela
Copy link
Contributor

+operations

@sunilUIET
Copy link
Contributor

+pdmv

@antoniovilela
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit edf3ebd into cms-sw:CMSSW_13_0_X Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants