Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from numberOfMatches() to segment number in DisplacedMuonFilterProducer #42763

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Sep 12, 2023

PR description:

plain backport of #41496 to 13.0.X

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Sep 12, 2023
@vlimant
Copy link
Contributor Author

vlimant commented Sep 12, 2023

enable nano

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2023

A new Pull Request was created by @vlimant (vlimant) for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @simonepigazzini, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @Ming-Yan, @hatakeyamak, @emilbols, @mbluj, @ahinzmann, @demuller, @seemasharmafnal, @mmarionncern, @Senphy, @jdolen, @azotz, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor Author

vlimant commented Sep 12, 2023

FYI @24LopezR

@vlimant
Copy link
Contributor Author

vlimant commented Sep 12, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86a836/34717/summary.html
COMMIT: 9342710
CMSSW: CMSSW_13_0_X_2023-09-12-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42763/34717/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 906 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283545
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283519
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12436
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12436
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.460 2.460 0.000 ( +0.0% ) 5.35 5.45 -1.8% 2.086 2.090
2500.311 2.595 2.595 0.000 ( +0.0% ) 4.84 4.91 -1.4% 2.521 2.521
2500.312 2.511 2.511 0.000 ( +0.0% ) 4.99 4.99 -0.1% 2.503 2.499
2500.33 1.253 1.253 0.000 ( +0.0% ) 10.30 10.41 -1.1% 2.212 2.213
2500.331 1.620 1.620 0.000 ( +0.0% ) 5.48 5.54 -1.1% 2.396 2.398
2500.332 1.502 1.502 0.000 ( +0.0% ) 7.90 7.98 -1.0% 2.313 2.313
2500.401 2.117 2.117 0.000 ( +0.0% ) 5.48 5.35 +2.4% 1.948 1.936
2500.501 1.723 1.723 0.000 ( +0.0% ) 9.30 9.33 -0.3% 1.832 1.829
2500.511 1.110 1.110 0.000 ( +0.0% ) 4.52 3.85 +17.3% 2.157 2.151
2500.5111 1.464 1.464 0.000 ( +0.0% ) 4.01 4.00 +0.4% 2.231 2.226
2500.601 1.983 1.983 0.000 ( +0.0% ) 13.11 13.17 -0.5% 1.711 1.707

@vlimant
Copy link
Contributor Author

vlimant commented Sep 13, 2023

changes seem to be consistent with what is expected from #41496 ; @24LopezR can you please confirm ?

@24LopezR
Copy link
Contributor

Yes, changes are consistent with what is expected.
I had a quick look at the failed comparisons. First, I noticed an increase in DSA Muons (type=8), which is expected. See WF 25202.0:

c_patMuons_slimmedDisplacedMuons__RECO_obj_type

Also, from numberOfMatches() histogram we observe an increase of muons in the region <2, which is also expected since now the filter is not acting in that region anymore for DSAs. Together with this comes a decrease in the region >=2, because there are DSAs that passed the old filter and now they fail. See comparison from WF 136.793:

c_patMuons_slimmedDisplacedMuons__reRECO_obj_numberOfMatches

These are the same effects seen in #41496

@vlimant
Copy link
Contributor Author

vlimant commented Sep 13, 2023

+1

@mandrenguyen
Copy link
Contributor

backport of #41496

Same comment as elsewhere, @cms-sw/orp-l2 do we backport to intermediate releases?

@mandrenguyen
Copy link
Contributor

type muon

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c8890a9 into cms-sw:CMSSW_13_0_X Sep 13, 2023
@antoniovilela
Copy link
Contributor

backport of #41496

Same comment as elsewhere, @cms-sw/orp-l2 do we backport to intermediate releases?

Yes, please backport to the intermediate release cycles.

@vlimant vlimant deleted the 13_0_backport_41496 branch March 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants