Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mu beamspot constrained pT. Increase mu eta and phi precision to 16 bits [13.0.X] #42762

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Add mu beamspot constrained pT. Increase mu eta and phi precision to 16 bits [13.0.X] #42762

merged 3 commits into from
Sep 14, 2023

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Sep 12, 2023

PR description:

plain backport of #42646

@vlimant
Copy link
Contributor Author

vlimant commented Sep 12, 2023

enable nano

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Sep 12, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2023 •
edited
Loading

A new Pull Request was created by @vlimant (vlimant) for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • RecoMuon/GlobalTrackingTools (reconstruction)

@cmsbuild, @simonepigazzini, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@bellan, @AnnikaStein, @andrea21z, @abbiendi, @JanFSchulte, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @CeliaFernandez, @gpetruc, @trocino, @amagitte, @cericeci, @rociovilar this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@vlimant vlimant changed the title backport of 42646 to 13.0.X Add mu beamspot constrained pT. Increase mu eta and phi precision to 16 bits [13.0.X] Sep 12, 2023
@vlimant
Copy link
Contributor Author

vlimant commented Sep 12, 2023

FYI @namapane

@vlimant
Copy link
Contributor Author

vlimant commented Sep 12, 2023

please test

@namapane
Copy link
Contributor

Thank you @vlimant !
But isn't this missing RecoMuon/GlobalTrackingTools/plugins/MuonBeamspotConstraintValueMapProducer.cc?

@cmsbuild
Copy link
Contributor

Pull request #42762 was updated. @cmsbuild, @simonepigazzini, @jfernan2, @mandrenguyen, @vlimant can you please check and sign again.

@vlimant
Copy link
Contributor Author

vlimant commented Sep 12, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e30717/34725/summary.html
COMMIT: 3aefeae
CMSSW: CMSSW_13_0_X_2023-09-12-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42762/34725/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 253 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283545
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3283519
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 9.700000000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1.166 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.769 KiB Physics/NanoAODDQM
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12436
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12436
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 10.841000000000001 KiB( 11 files compared)
  • DQMHistoSizes: changed ( 2500.311,... ): 1.166 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.331,... ): 0.769 KiB Physics/NanoAODDQM
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.460 2.460 0.000 ( +0.0% ) 5.42 5.45 -0.6% 2.034 2.090
2500.311 2.595 2.595 0.000 ( +0.0% ) 4.81 4.91 -2.0% 2.449 2.521
2500.312 2.511 2.511 0.000 ( +0.0% ) 5.02 4.99 +0.6% 2.450 2.499
2500.33 1.253 1.253 0.000 ( +0.0% ) 10.11 10.41 -2.9% 2.111 2.213
2500.331 1.620 1.620 0.000 ( +0.0% ) 5.44 5.54 -1.8% 2.272 2.398
2500.332 1.502 1.502 0.000 ( +0.0% ) 7.70 7.98 -3.6% 2.194 2.313
2500.401 2.117 2.117 0.000 ( +0.0% ) 5.50 5.35 +2.9% 1.943 1.936
2500.501 1.723 1.723 0.000 ( +0.0% ) 9.39 9.33 +0.7% 1.829 1.829
2500.511 1.110 1.110 0.000 ( +0.0% ) 4.51 3.85 +17.1% 2.129 2.151
2500.5111 1.464 1.464 0.000 ( +0.0% ) 4.03 4.00 +0.9% 2.103 2.226
2500.601 1.983 1.983 0.000 ( +0.0% ) 12.96 13.17 -1.6% 1.703 1.707

@cmsbuild
Copy link
Contributor

Pull request #42762 was updated. @cmsbuild, @simonepigazzini, @jfernan2, @mandrenguyen, @vlimant can you please check and sign again.

@vlimant
Copy link
Contributor Author

vlimant commented Sep 13, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e30717/34735/summary.html
COMMIT: 0af87de
CMSSW: CMSSW_13_0_X_2023-09-12-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42762/34735/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 259 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 27 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3283545
  • DQMHistoTests: Total failures: 990
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3282533
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 9.700000000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1.166 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.769 KiB Physics/NanoAODDQM
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12436
  • DQMHistoTests: Total failures: 34
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 10.841000000000001 KiB( 11 files compared)
  • DQMHistoSizes: changed ( 2500.311,... ): 1.166 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.331,... ): 0.769 KiB Physics/NanoAODDQM
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.469 2.460 0.008 ( +0.3% ) 5.46 5.36 +1.8% 2.085 2.089
2500.311 2.610 2.595 0.015 ( +0.6% ) 4.87 4.81 +1.4% 2.522 2.516
2500.312 2.522 2.511 0.010 ( +0.4% ) 5.06 5.00 +1.2% 2.510 2.498
2500.33 1.264 1.253 0.011 ( +0.9% ) 10.29 10.30 -0.1% 2.209 2.209
2500.331 1.634 1.620 0.015 ( +0.9% ) 5.46 5.46 -0.0% 2.399 2.394
2500.332 1.516 1.502 0.014 ( +1.0% ) 7.93 7.89 +0.5% 2.298 2.309
2500.401 2.126 2.117 0.009 ( +0.4% ) 5.48 5.45 +0.4% 1.945 1.944
2500.501 1.731 1.723 0.008 ( +0.4% ) 9.42 9.20 +2.4% 1.828 1.823
2500.511 1.125 1.110 0.015 ( +1.3% ) 4.55 4.50 +1.3% 2.150 2.149
2500.5111 1.479 1.464 0.015 ( +1.0% ) 3.98 3.82 +4.1% 2.230 2.230
2500.601 1.991 1.983 0.009 ( +0.4% ) 13.28 13.28 -0.0% 1.874 1.710

@vlimant
Copy link
Contributor Author

vlimant commented Sep 13, 2023

all changes expected

@vlimant
Copy link
Contributor Author

vlimant commented Sep 13, 2023

+1

@mandrenguyen
Copy link
Contributor

backport of #42646

@mandrenguyen
Copy link
Contributor

type muon

@cmsbuild cmsbuild added the muon label Sep 13, 2023
@mandrenguyen
Copy link
Contributor

+1

Are we skipping the intermediate backports?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@namapane
Copy link
Contributor

+1

Are we skipping the intermediate backports?

I can backport to other branches, just let me know which ones :-)

@mandrenguyen
Copy link
Contributor

@cms-sw/orp-l2 Should we also include this feature in 13_1 and 13_2?

@antoniovilela
Copy link
Contributor

@cms-sw/orp-l2 Should we also include this feature in 13_1 and 13_2?

Yes, in general we would like features implemented in an older cycle also in the intermediate ones.

This was referenced Sep 14, 2023
Merged
Merged
@namapane
Copy link
Contributor

@cms-sw/orp-l2 Should we also include this feature in 13_1 and 13_2?

Yes, in general we would like features implemented in an older cycle also in the intermediate ones.

Done (#42786, #42787).

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7ae27f6 into cms-sw:CMSSW_13_0_X Sep 14, 2023
@vlimant vlimant deleted the 13_0_backport_42646 branch March 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed muon orp-approved reconstruction-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
6 participants
@vlimant @cmsbuild @namapane @mandrenguyen @antoniovilela @rappoccio