Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v0_4_1 HI caloParams with updated centrality trigger thresholds #42697

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

mitaylor
Copy link
Contributor

@mitaylor mitaylor commented Sep 1, 2023

PR description:

Add L1T calo configs for heavy ion with updated centrality trigger thresholds for use in the 2023 run.

PR validation:

These files represent L1 configuration to be stored centrally, and are not involved in any central workflows.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Will need to backport to CMSSW_13_2_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42697/36793

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2023

A new Pull Request was created by @mitaylor (Molly Taylor) for master.

It involves the following packages:

  • L1Trigger/Configuration (l1)
  • L1Trigger/L1TCalorimeter (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5a673/34594/summary.html
COMMIT: 7ec1006
CMSSW: CMSSW_13_3_X_2023-09-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42697/34594/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 17 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3153350
  • DQMHistoTests: Total failures: 2310
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3151018
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 516619a into cms-sw:master Sep 4, 2023
@mitaylor mitaylor deleted the CMSSW_13_3_X_CaloParams_v0_4_1 branch October 17, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants