Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] remove duplicate monitoring of FB at layer1 data-emulator workspace #42658

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

hftsoi
Copy link
Contributor

@hftsoi hftsoi commented Aug 24, 2023

PR description:

This is to remove duplicate monitoring of FB at layer1 in the data-emulator DQM workspace.

PR validation:

This will be tested with DQM production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 24, 2023

A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for CMSSW_13_0_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@hftsoi hftsoi marked this pull request as draft August 24, 2023 22:27
@hftsoi hftsoi force-pushed the dataemu-fb-13-0-10 branch from 87c25b9 to a039c3a Compare August 24, 2023 22:54
@cmsbuild
Copy link
Contributor

Pull request #42658 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

@emanueleusai
Copy link
Member

please test

@emanueleusai
Copy link
Member

type hcal, l1t

@emanueleusai
Copy link
Member

testing at p5

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0903c9/34472/summary.html
COMMIT: a039c3a
CMSSW: CMSSW_13_0_X_2023-08-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42658/34472/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 247 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3281450
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3281418
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@hftsoi
Copy link
Contributor Author

hftsoi commented Aug 29, 2023

backport of #42677

@hftsoi hftsoi marked this pull request as ready for review August 29, 2023 10:57
@emanueleusai
Copy link
Member

tests at p5 completed successfully

@emanueleusai
Copy link
Member

+1

  • difference in HLT/SiStrip spurious
  • tests at p5 ok (checked by author)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

hold

  • Please sign the main branch PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2023

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@emanueleusai
Copy link
Member

master and other backports signed, can be unheld now

@rappoccio
Copy link
Contributor

unhold

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit b0da4ef into cms-sw:CMSSW_13_0_X Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants