Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirstVersionsofDiTauHLTPaths_forPhase2 [13_2_X] #42652

Merged

Conversation

hsert
Copy link
Contributor

@hsert hsert commented Aug 24, 2023

First versions of ditau HLT paths for Phase2 with charged isolation and DeepTau Isolation (using Run2 training) are added.

Detailed description of PR is given in the original PR: #42562

We would like that PR will be backported to CMSSW_13_2_X release, to be compatible wtih other Phase 2 HLT PRs.

I used CMSSW_13_2_X_2023-08-18-1100 release for testing. After initialization, the merged branch is rebased with
git cms-rebase-topic --old-base CMSSW_13_3_X_2023-08-15-1100 hsert:tauHLTPhase2_dev
and run the following runMatrix test, and there was no failed run.
runTheMatrix.py -l limited -i all --ibeos

…nd DeepTau Isolation (using Run2 training) are added.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hsert (HaleSert) for CMSSW_13_2_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato, @SohamBhattacharya, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

@hsert , the title of this PR is incomplete ("..."). Maybe take this opportunity to change the titles of your 3 PRs as follows: "foo" (master), "foo [13_2_X]" (this PR), and "foo [13_1_X]", where "foo" is the title of the PR to master.

@missirol
Copy link
Contributor

please test

@hsert hsert changed the title First versions of ditau HLT paths for Phase2 with charged isolation a… FirstVersionsofDiTauHLTPaths_forPhase2 [13_2_X] Aug 24, 2023
@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acbd1c/34460/summary.html
COMMIT: a4b12ad
CMSSW: CMSSW_13_2_X_2023-08-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42652/34460/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196410
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196388
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acbd1c/34461/summary.html
COMMIT: a4b12ad
CMSSW: CMSSW_13_2_X_2023-08-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42652/34461/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 21 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196410
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196379
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5837177 into cms-sw:CMSSW_13_2_X Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants